Quick Search Filter should be moveable

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3
Build Identifier: 3.0.4

Bug 545955 introduces a new Quicksearch Toolbar, but apparently loses the old/original QuickSearch Filter box that can be moved to any toolbar.

I do not want or need a new toolbar that takes up more vertical space in my UI. I use a netbook, and vertical screen real estate is precious.

I do like the sticky button for it, but that is all it needed, why duplicate all of the stuff from the 'View' selector as buttons? I don't need or want those.

Reproducible: Always

Steps to Reproduce:
Upgrade to 3.1
Actual Results:
Old QuickSearch box is gone, totally replaced by a new Quicksearch Toolbar.

Expected Results:
I want to be able to have the QuickSearch filter on my menu bar.

Ok, this is getting worse...

I was just helping one of my users that I have upgraded to 3.1 (now on rc2) because she was hitting bug 570804 constantly - the new 3.1 totally fixes it, so good work there!

Anyway, she was complaining that her searches weren't producing correct results. I finally realized it was because she didn't have 'recipient' clicked/enabled - but it took me a few minutes to even notice those new options just below the search box.

<sigh>

All the Quickfilter search box needed was the little sticky thumbtack added to it. Everything else worked just fine, although I do kind of like the idea of being able to individually select which of the criteria is enabled.

This is going to be a *huge* UI irritant for some of us. Every time I go into my rc2 install now it's like fingernails down a chalkboard, and I don't see it getting any better with time.

I honestly don't know if I'll be able to stand it, but I'm not sure what my options are... <sigh>

Why? Why did you have to go and convert a nice, neat, simple little search box into a huge monstrosity of a toolbar? This was totally and absolutely unnecessary.

Please, restore it to the way it was, but just with the little sticky pin next to it, and by all means include the ability to individually select the criteria, and I have an idea on how to do that very unobtrusively:

Show the currently selected criteria 'greyed out' inside the searchbox, like 3.0 does now, but when the dropdown/select box widget is clicked, instead of dropping down the pre-defined list of criteria combinations, drop down the *new* list of individual options just like they are now, so the user can click/select/deselect whichever ones they want active - then when the user clicks anywhere else on the GUI, the drop down goes away.

Please?

By the way - I didn't really make it clear, I'm not asking to kill the new toolbar - I'm just asking to *bring* *back* the ability to have the old quickfilter search box that can be moved to any other toolbar.

So, basically, an *optional* way to use the new quickfilter...

Maybe a 'Tools > Options > Advanced > General' option with a radio button or toggle choice of:

[ ] Use Quickfilter Toolbar
[ ] Use Quickfilter Searchbox Only

The toolbar takes up almost an inch of vertical real estate, which is a lot on a small screen...

I hope someone is listening.

By the way - most if not all of the performance bugs as well as the intermittent local cache/offline store corruption bugs seem to have been squashed, so in spite of this new GUI irritation, I will definitely be upgrading.

Question: Is the new Quickfilter toolbar coded in such a way (ie, are the hooks there) so that this could be fixed by an extension?

(In reply to comment #2)
> Question: Is the new Quickfilter toolbar coded in such a way (ie, are the hooks
> there) so that this could be fixed by an extension?

Anyone?

I can't answer your question, but...

(In reply to comment #0)
> I do not want or need a new toolbar that takes up more vertical space in my UI.
> I use a netbook, and vertical screen real estate is precious.

Did you notice you can hide the toolbar with a single click in the tab strip? It's the button with a looking glass on the right. You don't even have to click the button to temprorarily unhide it - just use Ctrl+F

> I do like the sticky button for it, but that is all it needed, why duplicate
> all of the stuff from the 'View' selector as buttons? I don't need or want
> those.

I'm not the person who designed this feature, but my excuses could be:
* view selector is ugly, doesn't allow combining filters and is hidden by default.
* making all filter buttons act as a widget placeable in the main toolbar would make this widget way too wide. I run Tb full-screen on a 1440px wide screen, have only one non-default buttons, and there isn't much free space in the toolbar left. Certainly not for the whole filter widget
* the menu bar may be hidden by default in future
* the quick filter bar is easy to show/hide

By the way, you may want to avoid adding comments not directly related to the bug you're commenting. It makes the comments (and the whole bug page) longer, and less attractive to read. ;)

I don't have time to understand or comment on all the details of this (including the details that don't belong here or elsewhere), but the bottomline of this bug uncovers a real problem that should be given attention. The summary isn't very good right now (sounds more radical than the actual proposals), which unfortunately distracts from the real problem of insufficient customizability after the introduction of new quick filter bar. After morphing the summary, IMO this could and should be confirmed.

(In reply to comment #4)
> I can't answer your question, but...
>
> (In reply to comment #0)
>> I do not want or need a new toolbar that takes up more vertical space in
>> my UI. I use a netbook, and vertical screen real estate is precious.

> Did you notice you can hide the toolbar with a single click in the tab
> strip? It's the button with a looking glass on the right. You don't even
> have to click the button to temprorarily unhide it - just use Ctrl+F

Sorry, I don't see that button anywhere... ?

>> I do like the sticky button for it, but that is all it needed, why duplicate
>> all of the stuff from the 'View' selector as buttons? I don't need or want
>> those.

> I'm not the person who designed this feature, but my excuses could be:
> * view selector is ugly,

What is most ugly to me is wasted space.

That said, if I could quickly toggle the Quickfilter toolbar on/off with the keyboard, that would be better than what I have now.

> doesn't allow combining filters

So apparently you didn't read all of comment 1 (read the last paragraph)? It addresses this...

> and is hidden by default.

So fix it and make it not hidden by default...

> * making all filter buttons act as a widget placeable in the main toolbar would
> make this widget way too wide.

So make the individual buttons moveable... The only button I need is the Read/Unread button, the rest is totally wasted space for me - not oto mention the huge amount of space between the Sticky Pin/buttons on the left side of the toolbar and the searchbox on the Right.

> I run Tb full-screen on a 1440px wide screen,

So you must hate the huge amount of empty space between the sticky pin/buttons and the searchbox?

> have only one non-default buttons, and there isn't much free space in the
> toolbar left. Certainly not for the whole filter widget

I don't want the whole widget - just the searchbox/sticky pin, and maybe the Read/Unread button.

> * the menu bar may be hidden by default in future

I have mine hidden now, and it auto-shows on mouse-over of the Window Title bar using the HideMenuBar extension.

> * the quick filter bar is easy to show/hide

Not for me... I'd really like to know how to do this.

> Not for me... I'd really like to know how to do this.

Do you ever read the responses you get? I've pointed you to the respective keyboard shortcuts when the tab bar is hidden 10 days ago already in your thread, http://forums.mozillazine.org/viewtopic.php?f=30&t=1924589 (and as
you confirmed that it worked, I assume you also read and tried it).

(In reply to comment #7)
>> Not for me... I'd really like to know how to do this.

> Do you ever read the responses you get?

Yes I do... why do you ask?

> I've pointed you to the respective
> keyboard shortcuts when the tab bar is hidden 10 days ago already in your
> thread, http://forums.mozillazine.org/viewtopic.php?f=30&t=1924589 (and as
> you confirmed that it worked, I assume you also read and tried it).

Actually, I didn't 'confirm' it, I simply said that it was better, but still not what I was after. I wasn't on my computer at the time to test it...

I never came back and added a new comment after actually trying it stating that it is very problematic because CTRL-F is shared with the Find toolbar as well - sorry, this functionality is just way too all over the place to be usable by normal users.

Making the new Quickfilter+Sticky pin available as a separate searchbox that can be placed on any toolbar, and with the new customizable drop-down/select box for the search criteria would totally solve all of these problems, because I already have a perfectly functional auto hide/show menu bar where I put everything else (and which is where I had the old Quickfilter searchbox).

(In reply to comment #5)
> The summary isn't very good right now (sounds more radical than the actual
> proposals), which unfortunately distracts from the real problem of
> insufficient customizability after the introduction of new quick filter
> bar. After morphing the summary, IMO this could and should be confirmed.

Just changed it - any better?

I agree with comment #5 that being able to somehow get a version of the quick
filter which fits on the regular toolbar (especially as a replacement for the
Gloda bar if it's not used) would be desirable. Thus, confirming RFE for the new summary, this looks specific enough.

Regarding the Ctrl+F conflict, it's unfortunate and handled in bug 564328, but currently the easiest way to get the quick-filter bar when it's hidden and the tab bar with the handle is not present.

Created attachment 454550
Screenshot 1: Current quick filter bar with toggle button

(In reply to comment #6)
> (In reply to comment #4)
> > I can't answer your question, but...
> >
> > (In reply to comment #0)
> >> I do not want or need a new toolbar that takes up more vertical space in
> >> my UI. I use a netbook, and vertical screen real estate is precious.
>
> > Did you notice you can hide the toolbar with a single click in the tab
> > strip? It's the button with a looking glass on the right. You don't even
> > have to click the button to temprorarily unhide it - just use Ctrl+F
>
> Sorry, I don't see that button anywhere... ?

Check out the screenshot.

> That said, if I could quickly toggle the Quickfilter toolbar on/off with the
> keyboard, that would be better than what I have now.

That's Control+F. Though since it shares its shortcut with the search-in-message bar, its effect is sometimes fuzzy...

> So apparently you didn't read all of comment 1 (read the last paragraph)? It
> addresses this...

No, I didn't. Hence the last paragraph in my initial comment.

> > I run Tb full-screen on a 1440px wide screen,
>
> So you must hate the huge amount of empty space between the sticky pin/buttons
> and the searchbox?

No, I don't care. Actually, I'd change it to have even more space on my windows PC, if I could, because on Windows, those filter buttons also have text labels by default, and there doesn't seem to be any way to toggle them off (Bug 575313).

(In reply to comment #11)
> Created an attachment (id=454550)
> Screenshot of the quick filter

Rimas, the toggle is hidden along with the tab bar when mail.tabs.autoHide is set to "true" and only one tab is present. Thus, the keyboard shortcut or going through the menus is the only way to get it back.

Right... Though I think it should also be fixed. Perhaps the toggle button should jump somewhere when the tab bar is not available?

(In reply to comment #10)
> I agree with comment #5 that being able to somehow get a version of the quick
> filter which fits on the regular toolbar (especially as a replacement for the
> Gloda bar if it's not used) would be desirable. Thus, confirming RFE for the
> new summary, this looks specific enough.

Thanks! :)

(In reply to comment #6)
>> Did you notice you can hide the toolbar with a single click in the tab
>> strip? It's the button with a looking glass on the right. You don't even
>> have to click the button to temprorarily unhide it - just use Ctrl+F

> Sorry, I don't see that button anywhere... ?

Oh - you said Tab strip - I have the Tab bar hidden except when I go into my calendar (not all that often)... so, off to file another feature request to also have a Quickfilter toolbar button that can be moved to a different toolbar, just like the two calendar buttons now can be.

Although I'm at a loss as to why someone would choose to marry it to the tab bar???

> Regarding the Ctrl+F conflict, it's unfortunate and handled in bug 564328, but
> currently the easiest way to get the quick-filter bar when it's hidden and the
> tab bar with the handle is not present.

Understood... Thanks for the bug pointer, I'll go post a comment, although they seem to suggest the shared key combo is intentional... I'd much prefer at least an *option* to change it - maybe Alt-F for one and Ctrl-F for the other...

(In reply to comment #13)
> Right... Though I think it should also be fixed. Perhaps the toggle button
> should jump somewhere when the tab bar is not available?

Nah, just another toolbar button that can be placed on any other toolbar, like was done for the calendar buttons is all that is needed...

It was asked on https://bugzilla.mozilla.org/show_bug.cgi?id=545955#c117 whether this can be implemented as an extension.

Yes, it can be implemented as an extension.

Something along the lines of this bug might be especially interesting /
effective in combination with something along this one:

Bug 526221 - Pressing Enter after quicksearch filter terms should do global search (combine the best of quick filters and "Search all messages")

Iow, space-efficient users that prefer cleaner UI could
a) remove global search box from toolbar (currently possible using toolbar
customization)
b) add new quick search box to toolbar (this bug 570815)
c) use new quick search box to start global searches when necessary (bug
526221)

(In reply to comment #17)
> Iow, space-efficient users that prefer cleaner UI could
> a) remove global search box from toolbar (currently possible using toolbar
> customization)
> b) add new quick search box to toolbar (this bug 570815)
> c) use new quick search box to start global searches when necessary (bug
> 526221)

I like it... as long as it didn't have any of the old problems of switching to a GLODA search by mistake...

As much as I screamed about GLODA when I first encountered it, I tested it at home and it does work well even on large mail stores once everything is fully sync'd...

Also, I'd like a way to disable this [Enter] key behavior (so that if the Enter key is pressed it does nothing), because some of our users consistently hit enter when using the Quickfilter, no matter how many times I tell them they don't need to, which brings inconsistent results when messages are not fully sync'd (which ours generally aren't, because of the size of the IMAP stores).

I have no idea what "GLODA" is but am very frustrated with the new quick search in 3.1. This bug report seems to cover my problem and provide a reasonable solution. I would like to simply be able to search for all emails from "Smith" and have them listed just as they were in version 3.0.5. With 3.1, I can find no way to do this.

Fix this PLEASE!

(In reply to comment #19)
> I have no idea what "GLODA" is

It is the new Global Search functionality in 3.x

In 3.0.x it was accessed through a *combined* local/Global searchbox, and which search type depended on if you were searching 'All Messages' (which resulted in a GLODA search) or one of the specific criteris, which resulted in a 'Quickfilter' of just the selected folder.

> but am very frustrated with the new quick search in 3.1. This bug report
> seems to cover my problem and provide a reasonable solution. I would like
> to simply be able to search for all emails from "Smith" and have them
> listed just as they were in version 3.0.5. With 3.1, I can find no way to
> do this.

You use the Quickfilter toolbar. It is more stable/reliable than the old combined searchbox, because the old/combined searchbox was buggy, and would sometimes perform GLODA searches when it wasn't set to 'All Messages'...

Also, I really like the new toggleable 'sticky pin', that lets you apply the current search criteria to different folders when they are clicked/selected.

This new search capability would be *perfect* if it was available in a simple searchbox (without the toolbar baggage), but with the new features (sticky-pin, and new selectable/individual criteria from a persistent drop-down select box), per this Feature Request.

The new 3.1 search bar is horrendous. The one before 3.1 worked great and did what it needed to do efficiently.

@Mike

So VOTE for this bug! ;)

voted!

Charles & friends, if you want this to move forward, I think we need a clearer picture of the desired UI. Iow, please provide at least two mockup screenshots (before and after typing a search word into the customizable quicksearch wigdet requested by this bug) to show what "selectable search criteria in persistent drop-down" should look like when the simple qs input widget is on the main toolbar (I suppose). It's certainly solvable, but right now I am having trouble envisioning the whole thing.

Honestly, what you guys had in versions prior to 3.1 was awesome. It worked as expected and did what I needed it to do. Now I type something in that new top search bar and it opens a new tab and then if I want to change the query, I need to close the tab, retype it, click here and there - it's just really kludgy. So, the top search box is essentially useless.

Then there's the second search bar that wastes space and keystrokes. 90% of the time I'm searching the subject and the sender, which was the default for my inbox. When I search sent, I believe it would remember that I wanted to search the recipient instead - this was awesome. I type and get a listing of what I want - voila. I change the query, it updates the results. Hit the X, I get my full listing back. Works just as expected and it's unobtrusive.

The previous setup was extremely effective and fast, and didn't waste real-estate - exactly what I needed it to do. I'm not sure why you guys changed the functionality because you hit the nail on the head with the previous version. I might try and figure out how to downgrade to the previous version as I use that search box *all* the time and the new one is unusable.

"I think we need a clearer picture of the desired UI."

Thomas, you can see the desired UI in action <a href=http://www.mozillamessaging.com/en-US/thunderbird/all-older.html>here</a> and examine the source code for the desired UI <a href=ftp://ftp.mozilla.org/pub/mozilla.org/thunderbird/releases/3.0.6/>here</a>.

Yes and no - the new Quick Filter bar has a different logic but individual buttons for the search items which can be freely combined, and new criteria to search for which haven't been present in the 2.0/3.0 search options.

Thus, such a compact Quick Filter bar would need to compromise between limited space in the main toolbar and retaining the functionality. I could think of a drop-down menu similar to the folder-column selection, where you simply check all criteria that you want to apply and then hit return to let it run. That menu would only be needed if you want to change the selection.

That should be intuitive enough, but some ASCII-art mockup may indeed be useful to get a better idea what this could look like and how to arrange the items within the drop-down menu.

Honestly, you guys just messed up on the new version. You did a great job with the older versions - this "upgrade" went in the wrong direction.

@Mike - please stop spamming this bug with repetetive complaints - it isn't helpful.

(In reply to comment #24)
> Charles & friends, if you want this to move forward, I think we need a
> clearer picture of the desired UI. Iow, please provide at least two
> mockup screenshots (before and after typing a search word into the
> customizable quicksearch wigdet requested by this bug) to show what
> "selectable search criteria in persistent drop-down" should look like
> when the simple qs input widget is on the main toolbar (I suppose).
> It's certainly solvable, but right now I am having trouble envisioning
> the whole thing.

I'll try - but I honestly think a more precise description/explanation
will suffice...

I'll try one more time, then if you still can't see what I'm talking about I'll see if I can create a visual representation... so, try this...

First, picture the old Quickfilter searchbox in 3.0...

If you recall, it displays the current selection criteria as a 'hint' - ie, 'greyed out' *inside* the searchbox itself. The 'hint' 'disappears' as soon as you click inside the searchbox, then reappears as soon as you clear the searchbox.

The 'hint' also acts as a 'drop-down' selectbox (with the little 'down-arrow' just inside the left-hand side of the searchbox indicating so) that allows you to choose from pre-defined/hard-coded selection criteria - 'All Messages', 'Subject', 'Sender', 'Subject & Sender', etc... (I don't remember exactly what they all are or what order, but hopefully this is enough to jog your memory and to make it clear what I'm talking about).

Apparently there are problems caused by the fact that this searchbox is a combination of the GLODA search (the 'All Messages' criteria), and the current (3.1) Quickfilter searchbox (the others), depending on the criteria you had selected. The obvious problem is, GLODA searches all accounts/folders, while the Quickfilter function only filters messages in the currently selected view/folder.

Now... what this bug is asking for is simple: keep the GLODA searchbox and the new Quickfilter searchbox separate, but create a new option that will enable me to choose *either* the 'Quickfilter Toolbar', or a 'Standalone Quickfilter Searchbox'. This new option would not alter the current behavior of the Quickfilter Toolbar.

BUT - when in 'Standalone' mode:

1. The 'Stickypin' will be permanently attached/tied to the left (or right, I don't care) side of the searchbox, so it goes where the searchbox goes,

2. The 'drop-down' 'selectbox' for the criteria would be brought back, but instead of the pre-defined/hard-coded criteria, each one - 'Sender', 'Recipient', 'Subject' and 'Body' - would now be available individually,

3. When the 'drop-down' selectbox is being used to select which criteria should be included, it should be 'persistent' - meaning, when I click the mouse on it, it should drop-down the list of *individual* criteria (ie, 'Sender', 'Recipient', etc), and as long as I don't click anywhere outside of the dropped-down list, it should stay down so that I can click on any of the 4 items in the list to enable/disable them. A simple checkmark beside each one would indicate if it was selected (checkmark) or not (no checkmark). When I'm done, just clicking anywhere outside the ...

Sorry for the dupe by the way... the 'collision detection' window is a bit confusing when you haven't had your first cup of coffee yet...

(In reply to comment #26)
> > "I think we need a clearer picture of the desired UI."
>
> Thomas, you can see the desired UI in action <a
> href=http://www.mozillamessaging.com/en-US/thunderbird/all-older.html>here</a>
> and examine the source code for the desired UI <a
> href=ftp://ftp.mozilla.org/pub/mozilla.org/thunderbird/releases/3.0.6/>here</a>.

nice try :) I don't think we can just go back to the old UI. When developers introduced quick filter bar, they had their reasons - problems of the old implementation. These problems still apply, even though we might not be all happy with the new implementation. To name a few:
- Having quick filter and global search in one box was confusing and undiscoverable; it was difficult to use because you would have to change dropdown options each time between local filter and global search (unless we implement some sort of potentially difficult magic to distinguish between the two, like ctrl+enter and such, see existing bugs)
- the old system of picking a predefined quick filter set of criteria from dropdown list was perceived by some as very inefficient and bulky. To provide all options for everyone, you need a list of about 10 different options (wild guessing), too many anyway, considering that all we want is any arbitrary combination of just 4 criteria: sender, recipient, subject, body. That's why we now have the much easier system of secondary toolbar with those 4 criteria to toggle and fine-tune results after the fact.

So what we need is an UI and/or behaviour that avoids those old problems,
e.g. something like Charles proposes in comment 31 (which just arrived, so not yet covered here). But still, it's complex enough and easier to discuss with pictures of mockup UI which really help to eliminate problems and ensure we're all talking about the same thing.

(In reply to comment #33)
> So what we need is an UI and/or behaviour that avoids those old problems,
> e.g. something like Charles proposes in comment 31 (which just arrived, so not
> yet covered here). But still, it's complex enough and easier to discuss with
> pictures of mockup UI which really help to eliminate problems and ensure we're
> all talking about the same thing.

It really isn't that hard - hopefully after you've read my last once or twice, you'll see it is really quite simple...

> - Having quick filter and global search in one box was confusing and
> undiscoverable; it was difficult to use because you would have to change
> dropdown options each time between local filter and global search (unless we
> implement some sort of potentially difficult magic to distinguish between the
> two, like ctrl+enter and such, see existing bugs)

Honestly, I never had any issues with it. For me it was always very intuitive and I would change the pull-down filters accordingly and always get the results I wanted. I would also show users in our organization how to use it and they picked it up really quickly. The previous search bar seemed to work in a similar fashion to Mac Mail, if I remember correctly, and that's really the kind of common-denominator user you need to look at. Kinda like the iPhone, it's limited compared to Android, but they're able to pull it off because most users never need the really advanced features. It doesn't mean those advanced features shouldn't be available, it just means that they can be efficiently hidden as the power users will be able to find them while conveniently keeping them out of the way for the average user.

> - the old system of picking a predefined quick filter set of criteria from
> dropdown list was perceived by some as very inefficient and bulky. To provide
> all options for everyone, you need a list of about 10 different options (wild
> guessing), too many anyway, considering that all we want is any arbitrary
> combination of just 4 criteria: sender, recipient, subject, body. That's why we
> now have the much easier system of secondary toolbar with those 4 criteria to
> toggle and fine-tune results after the fact.

I'd be curios how many (and what type) of people were seeing it as inefficient and bulky. I've been pushing Thunderbird out in our organization and my users have picked it up very quickly and really enjoyed the functionality of the quick search bar because I'd make sure to show them that it was there. I bet none of them would even change the filters because by default it searched the needed criteria for 90% of the users. They were not power users and don't want to futz around with advanced features as they wouldn't use them anyways so it fit the bill just right.

Right now the new setup is very good for a power user that really wants to get in there and dial in their search - but power users are usually the minority. The average user just wants to type in their query and see a listing of messages that matched the filter.

I would recommend trying to figure out a way to unify the two search boxes because two is really confusing (my UI friend just said the same thing when I showed it to him). Then if you really don't like the pull-down in the search box like in previous version, put a "criteria" button next to the search box so that they user can customize how their search is made. The real-estate is there and it doesn't waste needed real-estate elsewhere.

Alright Mike, we are now sufficiently aware that you and your company were happy with the old combined quick/global search. It's easy to imagine others weren't, even if I am not aware of statistical evidence in numbers (and have commented on that problem elsewhere). Still, please accept that the new quicksearch bar is something that other users (not only power users) will find useful, as it exposes valuable functionality at your fingertips that was hidden or not even available before (don't forget the other filter buttons like tags, attachments, unread etc. on the filter bar). E.g., only new qf bar will let you filter for messages that do or do not have a certain tag (yes, and it's not perfect and leaves a lot to be desired).

As a volunteer in bug triage, I personally agree with some of the problems that you raised, but things aren't as simple as your comments seem to suggest. The proposal of unifying global and quick search has been around since the inception of global search (and we have open bugs for that); fact is, though, that they have just been deliberately separated. So new quick search bar is certainly there to stay. And we're exploring ideas here how to add on that and make it better.

(In reply to comment 31)
Charles, thanks for providing more detailed explanation of envisioned UI in comment 31, although a mockup screenshot says more than many words... *sigh*
I'll post one right now...

Created attachment 459049
Screenshot 2: Proposed UI of optional simple quick filter widget on main toolbar

Charles, is this the proposed UI of the simple quickfilter widget that you describe in comment 31?

Properties of Simple Quick Filter Widget with sticky pin

a) can be added to main toolbar using toolbar customization
b) is a separate widget independent of Gloda global search widget
c) is optional; does not replace/alter/interfere with existing quick filter bar (?) (although we'd have to clarify the behaviour when both are shown; where does Ctrl+F focus go to etc.)
d) has a sticky pin next to it
e) has a criteria dropdown that does NOT pop up automatically
f) the criteria dropdown, once opened, is a semi-permanent menu panel with the following toggle buttons (with checkmarks represented by _/ ):
_/ sender
_/ recipient
_/ subject
   body
Search criteria panel will stay open so that you can tick what you need,
then click anywhere else or press ESC to make it disappear.
(Same behaviour as "Edit this bookmark" panel from yellow star in FF).

Sounds strange. I have Gloda disabled, too, but that doesn't influence the filtering possibility. And the dropdown arrow does in no way depend on Gloda or sth. Do you use the correct box? Please note that there is a new box for the unified search that you can place in the e.g. icon bar when customizing the bars. You can remove the global search box and the quick filter bar safely and only work with the unified search box as it can do both, filtering and search. You can switch between these functions with the magnifier glass/funnel icon.

because of changes in firefox: "Remote XUL (XUL through HTTP) has been removed
from Firefox 4 (see bug 546857 for more information). But there's still a whitelist that allows remote XUL access on a per-domain level

To allow the xul demos from bugzilla's attachments directly, you need
https://addons.mozilla.org/en-US/firefox/addon/remote-xul-manager/
then add https://bugzilla.mozilla.org/ to that xul-whitelist.

to allow local file://xul in current FF, goto about:config and set dom.allow_XUL_XBL_for_file -> true

mycae:

Iago's extension (Unified Search) has it's *own* searchbox that you have to *manually* add to one of your toolbars...

Also, the latest version (0.6.3) seems to have fixed all of the minor bugs, and added the 'x' to clear the searchbox... it is now working *oerfectly*, and is, imnsho, an excellent candidate for inclusion in the core code.

Would one of the devs please comment on whether or not there is a process in place for proposing extensions for inclusion in the core code?

Charles: There's no official procedure, but merging the quick filter and global search boxes is one of the things I'ld like to see happen. So, to move this forward, I think we can do one of two things. Either someone can add Iago's extension as an attachment, and ask me for ui-review, or someone (possibly Iago) can take the code from his extension and start turning it into a patch to Thunderbird.

I don't have a preference as to which way it happens. I suspect there will be some small tweaks I'll ask for ui-wise before it lands in core either way, so it sort of depends on what Iago wants to do.

Thanks,
Blake.

Created attachment 577917
Iago's Unified Search Addon (latest version, 0.6.4)

Hi Blake,

Here you go... and here's keeping my fingers crossed... ;)

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #124)
> Charles: There's no official procedure,

Hmmm... before I go open a bug/feature request for this, what would be the proper way to formally make such a suggestion?

Since an Addon is the ideal way to add new functionality 'outside the box', there really should be a formal procedure for proposing extensions for addition in the core code, and for vetting them and giving it a thumbs up/down - but imo this should be formally adopted by Mozilla for both Thunderbird and Firefox.

If you tell me a bug request is the best way, I'll go open one...

Comment on attachment 577917
Iago's Unified Search Addon (latest version, 0.6.4)

(Just asking myself for review, to put this in the queue.)

Comment on attachment 577917
Iago's Unified Search Addon (latest version, 0.6.4)

So, this is _kinda_ like what I was thinking of, but I don't think it's close enough to get a ui-r+.

The main thing I dislike is that it feels _way_ too cluttered.

Four icons in the search box is three and a half too many.

Manually having to switch between filter and global search forces me to make a decision before I feel I should.

The extra bar seems to pop up at odd times.
  I don't feel like I have any control over it.

http://dl.dropbox.com/u/2301433/Screenshots/SearchBar/GlobalSearch.png shows some extra icons beside the global search.
  What are they for? Is that just a bug?

I realize that there is a conflict here between ux-minimalism and ux-discovery, but I think we need to go further towards the minimalism side of things than this current add-on does.

Thanks,
Blake.

Hi Blake,

thanks for looking at this... comments inline...

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #128)
> Comment on attachment 577917
> Iago's Unified Search Addon (latest version, 0.6.4)
>
> So, this is _kinda_ like what I was thinking of, but I don't think it's
> close enough to get a ui-r+.
>
> The main thing I dislike is that it feels _way_ too cluttered.

As compared to the Quickfilter Toolbar?

Remember, this is designed to *replace* the entire QF toolbar.

It also auto-expands/contracts, depending on how much room is available where it is placed.

> Four icons in the search box is three and a half too many.

I agree to an extent, and would like to see this configurable. Personally, I'd like only the Pin icon and a Read/Unread toggle (those are the only ones I use a lot).

> Manually having to switch between filter and global search forces me to make
> a decision before I feel I should.

Not sure what you mean here, but I don't use the Global Search (have GLODA completely disabled)...

> The extra bar seems to pop up at odd times.

Haven't noticed this... and I use it heavily and have a lot of other extensions - maybe a conflict with one you have?

> I don't feel like I have any control over it.

I have zero problems with it, and like I said, use it heavily. Can you elaborate a little?

> http://dl.dropbox.com/u/2301433/Screenshots/SearchBar/GlobalSearch.png shows
> some extra icons beside the global search.
> What are they for? Is that just a bug?

I only see the clear button, the button to switch back to Filter mode, and the Prefs button - what other buttons are you talking about?

> I realize that there is a conflict here between ux-minimalism and
> ux-discovery, but I think we need to go further towards the minimalism side
> of things than this current add-on does.

It is already vastly more minimalistic than the QF toolbar, so what are you contrasting it to?

I'm not trying to be argumentative, I honestly don't see the problems youare talking about...

(In reply to Charles from comment #129)
> (In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #128)
> > So, this is _kinda_ like what I was thinking of, but I don't think it's
> > close enough to get a ui-r+.
> >
> > The main thing I dislike is that it feels _way_ too cluttered.
> As compared to the Quickfilter Toolbar?
> Remember, this is designed to *replace* the entire QF toolbar.

No, as compared with something I would want to add to Thunderbird. ;)

> It also auto-expands/contracts, depending on how much room is available
> where it is placed.

I don't know how much of a feature that is. I think I would be confused if things moved around too much when I resized the window. (Perhaps that's not how it works. Perhaps it's not actually that confusing.)

> > Four icons in the search box is three and a half too many.
> I agree to an extent, and would like to see this configurable. Personally,
> I'd like only the Pin icon and a Read/Unread toggle (those are the only ones
> I use a lot).

I don't know of many search fields that have more than one active thing in them. (Even Firefox's has only one _active_ thing, and the two icons it contains are on opposite sides, and thus less cluttered feeling.) For this reason, I don't think letting people put _more_ icons into the text area is the right thing to do.

> > Manually having to switch between filter and global search forces me to make
> > a decision before I feel I should.
> Not sure what you mean here, but I don't use the Global Search (have GLODA
> completely disabled)...

Hmm. So when I just tried it, I typed a string, then switched from filter to gloda, and the string disappeared. I just tried the reverse now, and it seemed to work okay. Perhaps it was just a bug I hit…

> > The extra bar seems to pop up at odd times.
> Haven't noticed this... and I use it heavily and have a lot of other
> extensions - maybe a conflict with one you have?

I only have lightning installed.

> > I don't feel like I have any control over it.
> I have zero problems with it, and like I said, use it heavily. Can you
> elaborate a little?

I suspect the fact that you use it heavily is the difference here.
For me, as a first-time user of the add-on, it feels cluttered and confusing.

(I also suspect that you have a higher tolerance for complexity than I do… :)

> > http://dl.dropbox.com/u/2301433/Screenshots/SearchBar/GlobalSearch.png shows
> > some extra icons beside the global search.
> > What are they for? Is that just a bug?
> I only see the clear button, the button to switch back to Filter mode, and
> the Prefs button - what other buttons are you talking about?

The ones to the left of the words "Messages mentioning: Mike".

> > I realize that there is a conflict here between ux-minimalism and
> > ux-discovery, but I think we need to go further towards the minimalism side
> > of things than this current add-on does.
> It is already vastly more minimalistic than the QF toolbar, so what are you
> contrasting it to?
> I'm not trying to be argumentative, I honestly don't see the problems youare
> talking about...

So, I've got a picture of all the bars up at
http://dl.dropbox.com/u/230143...

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #130)
> (In reply to Charles from comment #129)
>> (In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #128)
>>> The main thing I dislike is that it feels _way_ too cluttered.

>> As compared to the Quickfilter Toolbar?
>> Remember, this is designed to *replace* the entire QF toolbar.

> No, as compared with something I would want to add to Thunderbird. ;)

But...

a) we are talking about bringing something back that was *removed* that a *lot* of people liked and want to see brought back, and

b) as I said before, it is not nearly as 'cluttered' as what replaced it (the QF toolbar).

>> It also auto-expands/contracts, depending on how much room is available
>> where it is placed.

> I don't know how much of a feature that is.

It is nice, just like the way the Awesomebar (in Firefox) auto expands/contracts...

> I think I would be confused if things moved around too much when I resized
> the window. (Perhaps that's not how it works. Perhaps it's not actually
> that confusing.)

It isn't, and it isn't... ;)

It doesn't 'move around', it simple takes up more or less space, depending on how much room is available.

>>> Four icons in the search box is three and a half too many.

> I don't know of many search fields that have more than one active thing in
> them. (Even Firefox's has only one _active_ thing, and the two icons it
> contains are on opposite sides, and thus less cluttered feeling.) For this
> reason, I don't think letting people put _more_ icons into the text area is
> the right thing to do.

I was mainly talking about making iit configurable so that you could DEselect ones - I don't see a need for others to be there either.

>>> The extra bar seems to pop up at odd times.
>> Haven't noticed this... and I use it heavily and have a lot of other
>> extensions - maybe a conflict with one you have?

> I only have lightning installed.

Dunno then... it doesn't do this for me though.

> I suspect the fact that you use it heavily is the difference here.
> For me, as a first-time user of the add-on, it feels cluttered and confusing.
>
> (I also suspect that you have a higher tolerance for complexity than I do…
> :)

Maybe, but I also think that the fact that I don't use GLODA/Global Search ever has something to do with it too.

> > > http://dl.dropbox.com/u/2301433/Screenshots/SearchBar/GlobalSearch.png shows
> > > some extra icons beside the global search.
> > > What are they for? Is that just a bug?
> > I only see the clear button, the button to switch back to Filter mode, and
> > the Prefs button - what other buttons are you talking about?
>
> The ones to the left of the words "Messages mentioning: Mike".

Oh... the 'Messages mentioning: Mike' pop-out is actually covering up the rest - look and you'll see that those are the filter options, and the ones that are hidden are the attachment icon, and then the 'Sender, Recipients, Subject and Body options.

> So, I've got a picture of all the bars up at
> http://dl.dropbox.com/u/2301433/Screenshots/SearchBar/GlobalSearch.png
>
> You'll notice that the add-on has four buttons in the text box, as opposed...

Created attachment 582081
What the Unified Search addon looks like in Filter mode with the options showing horizontally

(In reply to Charles from comment #131)
> (In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #130)
> > (In reply to Charles from comment #129)
> >> (In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #128)
> >>> The main thing I dislike is that it feels _way_ too cluttered.
>
> >> As compared to the Quickfilter Toolbar?
> >> Remember, this is designed to *replace* the entire QF toolbar.
> > No, as compared with something I would want to add to Thunderbird. ;)
> But...
> a) we are talking about bringing something back that was *removed* that a
> *lot* of people liked and want to see brought back, and

Perhaps the problem is that I'm not talking about bringing back anything…

> > > > http://dl.dropbox.com/u/2301433/Screenshots/SearchBar/GlobalSearch.png shows
> > > > some extra icons beside the global search.
> > > I only see the clear button, the button to switch back to Filter mode, and
> > > the Prefs button - what other buttons are you talking about?
> > The ones to the left of the words "Messages mentioning: Mike".
> Oh... the 'Messages mentioning: Mike' pop-out is actually covering up the
> rest - look and you'll see that those are the filter options, and the ones
> that are hidden are the attachment icon, and then the 'Sender, Recipients,
> Subject and Body options.

But if I'm showing the global "Messages mentioning: Mike", how are those filter options showing?

> > So, I've got a picture of all the bars up at
> > http://dl.dropbox.com/u/2301433/Screenshots/SearchBar/GlobalSearch.png
> > You'll notice that the add-on has four buttons in the text box, as opposed
> > to one icon for each of the QFB and GlodaBar.
>
> Correct, but...
>
> That picture shows that you are in Global Search mode, not Filter mode. This
> extension is *primarily* meant to be used for filtering, not Global
> Searching, that part was added later. Switch to Filter mode (click the mode
> toggle button, which is the Magnifying glass icon) and experiment with that
> for a while...

Right, then there are "only" three buttons, instead of the one for QFB and Gloda…

Also, the fact that there are two different modes is one of the problems I have with it.

> > For the add-on's popup, there's no indication of what the various icons are,
> > or which keys I would use to activate them.
> If you mouse-over them, you get tooltip descriptions of what they do.

And if I'm blind? Even if I'm sighted, mousing-over and waiting for several tooltips before I finally find the icon I want is a bad UX by any measure.

> > For the add-on, to clear the options, Esc+Esc is a _horrible_ key
> > combination.
> So do like I do and just click the little x icon.

That there is an alternative doesn't make Esc+Esc a good UX.

> > (I also have no idea what "Clear Options" actually does…)
> It clears the searchbox text and any of the options (show Unread only, show
> Starred only, Show only messages with Attachments, etc)...

So, I mention all of these things not so that you can explain them, because I'm sure there are answers to any of them, but to demonstrate that there are a large number of things that are confusing to people who have never used the add-on before...

Hi Blake and Charles,

 Sorry for the delay and thank you for debate.
 Let me explain some tips.

 Unified Search extension borns like a proof concept for the Bug 526221, because some things was dicussed about what is better and what worse, but without possibilities to test it (sometimes, something can seem bad when speeking about but good or no-so-bad when testing it). The extension exists only like attachments in that bug and not published at AMO, was not intended like a production extension. But works well enought, no progress was in resolution of that bug and I decide released.
 Later, a quick solution for Bug 520040 (it's no smart, but works and is only one line solution), and from 0.5 version an implementation for this Bug extremely based on the attached Thomas's mockups. And the idea was the same: to be a proof concept, an extension to test different features, behaviors, to select what is best, what is bad, what can be improved. Not was intented to be exactly the final solution, I'm sorry if this was what seems.

 On other hand, let me say, Blake, all you pointed like possible bugs, really are, but seems happens only to you (works good for me, and seems works for Charles), I must continue testing it to discovered and solve it. But the topic is not this, the extension is not builded to be 'as is' included in the Thunderbird code, because technical reasons; can be useful for daily use by power users and useful to speek about what features and how must be included in Thunderbird, like we are doing now, and this last is really its goal.

 For example, Unified Search include three alternatives to unified global and filter boxes:
 - Give to the Thunderbird Global Search box filter capabilities (active it from the extension options).
 - Give to the Thunderbird Quick Filter box global search capability (active it from the extension options and disable 'hide quick filter bar' and 'hide quick filter box'; then, press Ctrl+Enter when using the standard filter box to open a global search -press only the Enter key is an available option, but disabled by default because was discussed previously and don't like to several users that use Enter to speed up the filtering, that have a timeout-). By default (without the extension), a global search can be opened from the filter box only when there are no results, with extension you can do it ever.
 - Create a new widget, with both capabilities: current Unified Search Widget do this, but includes several options for testing only:
   - Horizontal bar, vertical bar, and a button to show/hide it (and also a shortcut, press Down key when in widget box): final widget implementation must only include one of them, vertical Or horizontal, and maybe the button can be removed or changed in some way; will be simplier than now, but both options was included because was discussed previously with the Thomas's mockup, extension can be used to test both options and choice the bests (or evolve one of them); "test it to decide", and not only "think about it to decide", was my contribution to help in the process of choosing a solution.
   - Widget working 'all in one', or with two differents modes (one for only search, one for...

Thanks Charles for yours explanations, and Blake for the criticism, we need both to be better!

I'm sorry again that I wrote my previous comment before know that new commens come in (the three last); I decide published anyway because is valid yet.

Blake, if Esc+Esc (and Esc+Esc+Esc) seems you a design error, another bug must be created because of is a feature included in Thunderbird, I only replicated in my extension to match the default behavior (more explanations in my previous comment).

Thanks everybody,
IagoSRL

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #133)
> (In reply to Charles from comment #131)
>> (In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #130)
>>> (In reply to Charles from comment #129)
>>>> (In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #128)

>> a) we are talking about bringing something back that was *removed* that a
>> *lot* of people liked and want to see brought back, and

> Perhaps the problem is that I'm not talking about bringing back anything…

Well, that is the point of this whole bug - I should know, I am the one who opened it.

>> That picture shows that you are in Global Search mode, not Filter mode. This
>> extension is *primarily* meant to be used for filtering, not Global
>> Searching, that part was added later. Switch to Filter mode (click the mode
>> toggle button, which is the Magnifying glass icon) and experiment with that
>> for a while...

> Right, then there are "only" three buttons, instead of the one for QFB and
> Gloda…

? in Filter mode, there are *4* buttons

> Also, the fact that there are two different modes is one of the problems I
> have with it.

Flexibility sometimes comes with a certain level of complexity, but I don't think this is all that complicated, it just takes a little experimentation and getting used to how it works.

As Iago has said, apparently there are some bugs in the Global mode functionality, so maybe you can help him get them fixed?

>>> For the add-on's popup, there's no indication of what the various icons are,
>>> or which keys I would use to activate them.

>> If you mouse-over them, you get tooltip descriptions of what they do.

> And if I'm blind?

Then you'd be having similar problems with the QFB wouldn't you? I don't see your point.

> Even if I'm sighted, mousing-over and waiting for several tooltips before I
> finally find the icon I want is a bad UX by any measure.

Well, then, since tooltips are used in lots of places in both Thunderbird and Firefox (and lots of other programs), I guess they *all* have lots of 'bad UX'.

Come on, Blake... it only takes mousing over them a few times before you learn what they do and then there's no more need to mouse over them ever again, and you *know* it, so why are you being so disingenuous about this?

> For the add-on, to clear the options, Esc+Esc is a _horrible_ key
> combination.

And what would you call having to use 'Ctrl-F' to enable the 'Find in message' filter, and then have to use 'Esc' to hide it again? At least the nonsensical *double* use of 'Ctrl-f' (depending on context) and double-esc for toggling the QFB and/or the 'Find in message' filters was finally sort-of fixed (I still hate it, but it is less painful now).

>> So do like I do and just click the little x icon.

> That there is an alternative doesn't make Esc+Esc a good UX.

So maybe you can suggest a way to improve it?

Really, Blake, it sounds like you're looking to bash this addon just because - well, I honestly don't know why. Maybe you're offended that there are a lot of people who don't agree with the decision to *lose* the message filter searchbox rather than just add the QFB as a new *optional* ...

Created attachment 582556
Thunderbird with menubar hidden

This is my thunderbird with the menubar hidden (using the 'Hide Menubar' addon. With this addon, the menubar will auto-hide itself after a specified interval (unless the textbox for the 'Unified Search' addon has focus), and show itself drop down) on mouseover of the window titlebar (next attachment will have the menubar showing).

Created attachment 582557
thunderbird with the menubar showing after mouse-over of the window title bar

As described, this shows the menubar after I mouse-over the window titlebar.

Created attachment 582561
Firefox with tabbar hidden

This is how my Firefox looks with the 'Personal Titlebar' addon installed, and *everything* placed on the menubar. Also, I use the 'Tree Style Tab' addon to move the tabbar to the left side, and have the auth-hide funcionality enabled, which uses a *panel* to show the tabbar instead of forcing the whole window to move to the right when the tabbar pops out (note that you can see the webpage through/behind the tabbar).

This is absolutely *ideal* for a netbook or any small screen, but is also very pleasant on a large monitor as well.

Created attachment 582563
Firefox with tabbar showing

Sorry, in my last I said you could see the web page behind the tabbar, but that one was with the tabbar hidden.

This is the one with the tabbar showing in a panel, so you can see the webpage 'behind' the tabbar...

Surprisingly I'm pretty much liking the addon. One nit is if I filter on X in tab A and then on Y in tab B, that Y is shown in tab A when I go back to A. Even though A is still filtered on X.

That said, this bug seems to have gone off the rails, starting in comment 115 - 117, and 124. Let me point out that *Blake didn't start this*, and the direction wasn't brought back in focus by anyone back then, until ~comment 129, that the addon doesn't focus on what you (Charles) want.

STM the current addon focused on reunification and it's conversation should probably go in a different bug. Not that it will change the direction of the addon - which seems clear enough to me - but it may help get this bug back on topic. How quickly it progresses is a different matter.

(In reply to Wayne Mery (:wsmwk) from comment #141)
> Surprisingly I'm pretty much liking the addon. One nit is if I filter on X
> in tab A and then on Y in tab B, that Y is shown in tab A when I go back to
> A. Even though A is still filtered on X.

Well, again, since I don't use tabs, I would never have encountered those issues... most likely Iago can fix them though if you report it to him...

> That said, this bug seems to have gone off the rails, starting in comment
> 115 - 117, and 124. Let me point out that *Blake didn't start this*, and the
> direction wasn't brought back in focus by anyone back then, until ~comment
> 129, that the addon doesn't focus on what you (Charles) want.

Not sure what you mean... the addon totally fulfills this bug request. We - users - are often told that an Addon is a good way to get a feature implemented, because then the code is already written, and thus, the Unified Search Addon was born.

> STM the current addon focused on reunification

No, initially, the Addon focused precisely on fulfilling my original request, as hammered out in the mockups so artfully done by Thomas D. The 'unification' aspect (unifying the Global Search etc) was added *afterwards*...

> and it's conversation should probably go in a different bug. Not that it will
> change the direction of the addon - which seems clear enough to me - but it
> may help get this bug back on topic. How quickly it progresses is a different
> matter.

Again, I don't follow. This addon *totally* fulfills my request, so please I wish you guys would stop telling me that it doesn't - I should know, I made it, and am using (and now totally dependent on), and that is why I'm now asking for the Unified Search addon to be incorporated into the core code (since that would be the last step in fulfilling this bug request).

(In reply to Charles from comment #142)
> (In reply to Wayne Mery (:wsmwk) from comment #141)
> > Surprisingly I'm pretty much liking the addon. One nit is if I filter on X
> > in tab A and then on Y in tab B, that Y is shown in tab A when I go back to
> > A. Even though A is still filtered on X.
>
> Well, again, since I don't use tabs, I would never have encountered those
> issues... most likely Iago can fix them though if you report it to him...
>
> > That said, this bug seems to have gone off the rails, starting in comment
> > 115 - 117, and 124. Let me point out that *Blake didn't start this*, and the
> > direction wasn't brought back in focus by anyone back then, until ~comment
> > 129, that the addon doesn't focus on what you (Charles) want.
>
> Not sure what you mean... the addon totally fulfills this bug request. We -
> users - are often told that an Addon is a good way to get a feature
> implemented, because then the code is already written, and thus, the Unified
> Search Addon was born.

Perhaps there is a misunderstanding. because
a) I said nothing about not doing an addon, and
b) your bug summary says nothing about reunification

> > STM the current addon focused on reunification
>
> No, initially, the Addon focused precisely on fulfilling my original
> request, as hammered out in the mockups so artfully done by Thomas D. The
> 'unification' aspect (unifying the Global Search etc) was added
> *afterwards*...
>
> > and it's conversation should probably go in a different bug. Not that it will
> > change the direction of the addon - which seems clear enough to me - but it
> > may help get this bug back on topic. How quickly it progresses is a different
> > matter.
>
> Again, I don't follow. This addon *totally* fulfills my request, so please I
> wish you guys would stop telling me that it doesn't - I should know, I made
> it, and am using (and now totally dependent on), and that is why I'm now
> asking for the Unified Search addon to be incorporated into the core code
> (since that would be the last step in fulfilling this bug request).

then apparently I have goofed, and am happy to say so. it would help please to change your bug title/summary so one doesn't have to read 100+ comments to understand the basics of the bug, and get summarily blasted when we make seemingly useless comments. maybe even resummarize the goal. Bear in mind, if you conflate multiple goals, the patch is much more complex, and less likely to be accepted into core - addon or no addon.

big kudos to Iago and all for working to improve Tbird.
W.

(In reply to Charles from comment #136)
> (In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #133)
> >> a) we are talking about bringing something back that was *removed* that a
> >> *lot* of people liked and want to see brought back, and
> > Perhaps the problem is that I'm not talking about bringing back anything…
> Well, that is the point of this whole bug - I should know, I am the one who
> opened it.

Ah, in that case, I'm not really in favour of this, since that sounds like just adding yet more search boxes to confuse our users with. (Although, with 144 comments, it's possible I'm _still_ misunderstanding the point of this bug.)

> > Also, the fact that there are two different modes is one of the problems I
> > have with it.
> Flexibility sometimes comes with a certain level of complexity, but I don't
> think this is all that complicated, it just takes a little experimentation
> and getting used to how it works.

I disagree, which seems to put us at an impasse.

Our user-testing has shown that people have problems with the two search bars, and trying to figure out which one to use for what kind of searches. Merging them into a single bar that sometimes does what you want and sometimes doesn't doesn't seem to me to be a good way to resolve that issue, and I think we can do better than that.

> > For the add-on, to clear the options, Esc+Esc is a _horrible_ key
> > combination.
> And what would you call having to use 'Ctrl-F' to enable the 'Find in
> message' filter, and then have to use 'Esc' to hide it again? At least the
> nonsensical *double* use of 'Ctrl-f' (depending on context) and double-esc
> for toggling the QFB and/or the 'Find in message' filters was finally
> sort-of fixed (I still hate it, but it is less painful now).

That was another key combo didn't work out. (I'm also not particularly happy with the current set of key combos, but if we ever manage to merge the QFB and Gloda bars, we can just use Ctrl-K, which is better, I think.)

> Really, Blake, it sounds like you're looking to bash this addon just because
> - well, I honestly don't know why.

I'm not trying to bash the add-on (and said so to Iago in email), I'm just trying to point out things that I would want to see improved/fixed before landing something like this in Thunderbird.

> Maybe you're offended that there are a
> lot of people who don't agree with the decision to *lose* the message filter
> searchbox rather than just add the QFB as a new *optional* way to filter
> messages, and that someone very capable (thanks Iago!) actually stepped up
> and did something about it?

Well, it wasn't my decision, so I'm not particularly offended. (But I'm also not convinced that only ever adding things, and never taking things away is a path that will lead to good software.)

> > Not being a toolbar doesn't make it more minimal. Neither does making it
> > smaller. (For that matter, neither does removing text labels from iconic
> > buttons.)
> Ok, Blake, no offense, but you simply cannot be serious. It *does* make it
> more 'minimal', in the sense that it takes up less *space* *and* allows the
> user the freedom to put the searchbox wherever they want an...

(In reply to Blake Winton [On vacation until Jan 9th] (:bwinton - Thunderbird UX) from comment #144)
> (In reply to Charles from comment #136)
> Our user-testing has shown that people have problems with the two search
> bars, and trying to figure out which one to use for what kind of searches.
> Merging them into a single bar that sometimes does what you want and
> sometimes doesn't doesn't seem to me to be a good way to resolve that issue,
> and I think we can do better than that.

One option then would be to make it an either/or option - meaning, you can't have both, and I certainly have no problem with making the Quick Filter Toolbar the default one that is enabled, but allow the user to choice to *switch* to the Widget (movable/standalone searchbox that this extension provides), and pop-up a little warning explaining the difference between the two search options (Toolbar, or Widget) to the user when they change the option so it is clear what they are doing, and that enabling the widget would disable the Toolbar.

That way there is no possibility for confusion.

> That was another key combo didn't work out. (I'm also not particularly
> happy with the current set of key combos, but if we ever manage to merge the
> QFB and Gloda bars, we can just use Ctrl-K, which is better, I think.)

Well, since I do not use GLODA for reasons already explained (it is absolutely *horrible* when used with very large IMAP stores), I certainly hope you aren't suggesting that GLODA will be something else I'll be *forced* to use at some point in the future...

> I'm not trying to bash the add-on (and said so to Iago in email), I'm just
> trying to point out things that I would want to see improved/fixed before
> landing something like this in Thunderbird.

Ok, and your hard work is much appreciated, even though sometimes it may not come out that way...

I had a few exchanges with Iago about simplifying the Widget, so hopefully I'll be able to post back here to try the new version soon and maybe some of your concerns will be addressed.

> Well, it wasn't my decision, so I'm not particularly offended. (But I'm
> also not convinced that only ever adding things, and never taking things
> away is a path that will lead to good software.)

Definitely me neither... but this is not one of those times. I absolutely love this addon, and can't imagine Thunderbird without it.

>> Ok, Blake, no offense, but you simply cannot be serious. It *does* make it
>> more 'minimal', in the sense that it takes up less *space* *and* allows the
>> user the freedom to put the searchbox wherever they want and be able to
>> filter messages without having another huge toolbar taking up more precious
>> screen real estate, which is *the* *whole* *point*.

> I see that you and I are talking about two completely different things.
>
> I don't care how much space we take up, if we get an easier to use program.

Sorry, again, no offense, but that comment just screams 'I know nothing about *good* UI design."

> You seem to not care how easy something is to use, as long as it takes up as
> little space as possible.

Well, I see essentially *zero* difference in 'ease of use' between the Toolbar an...

Hi,

thanks everyone for the passionate discussion. I normally refrain from these kinds of "me too"-comments because they add nothing. I thought adding myself to the cc and voting for the bug had been enough of a "me too" but apparently it's not enough to convince Blake that Charles isn't the only one with this issue and that he indeed IS waiting for more vocal complaints.

So, I hope you don't mind me weighing in here.

Yes, Gloda is absolutely horrible - in sooo many ways
Yes, I was considering to dump TB because of it but there's so many other battles to fight and no immediate replacement
No, Charles is not the only one VERY frustrated about the process

Thank you for your consideration.

Hi,

thanks everyone for the passionate discussion. I normally refrain from these kinds of "me too"-comments because they add nothing. I thought adding myself to the cc and voting for the bug had been enough of a "me too" but apparently it's not enough to convince Blake that Charles isn't the only one with this issue and that Blake indeed IS waiting for more vocal complaints.

So, I hope you don't mind me weighing in here.

Yes, Gloda is absolutely horrible - in sooo many ways
Yes, I was considering to dump TB because of it but there's so many other battles to fight and no immediate replacement
No, Charles is not the only one VERY frustrated about the process

Thank you for your consideration.

Things I passionately dislike (shall I say hate?) about Gloda or whatever it's called

- takes up precious screen real estate
- confusing UI
- ugly
- destroyed something that was working fine
- Ctrl+A has to be the most stupid choice possible for key combo, that's "Select all" everywhere else

I don't use Gloda, it's not the way I search.

Created attachment 586178
Latest version of the Unified Search addon (0.7.1)

Ok, figured I'd upload the latest version of the Addon (still not approved on AMO because of some harmless errors showing in the console that Iago is working on correcting). This one fixed a bug I was experiencing where the Filter options (in the horizontal panel) were not working.

Also, after my conversation with Iago, I think he is going to be removing the optional Vertical menu (that I agree was confusing, but I never used it), which will mean that last button inside the searchbox (on the right side) will be gone.

One other thing that causes confusion for us here in the office is, in spite of the fact that GLODA is disabled, the Addon still allows the user to toggle into Global Search mode, which does nothing when GLODA is disabled. I think he is going to fix it so that when GLODA is disabled, that button/icon for toggling between Filter and Global Search modes will not be displayed.

Hi every body,

I will work in next days in some news widget concepts, trying to simplify current widget (that is overloaded). I want too remove the needed of two modes on the widget mantaining the global suggestions when gloda enabled and some enhancements when disabled, and remove vertical menu and some buttons wih all this. But all this are ideas only now, i need concrete some tips and implementing it for testing.
Please be patient, and stay tunned ;-)

Thanks

Thanks very much Iago... please don't hesitate to ping me if you would like feedback on any beta builds...

please can we agree that this bug is not about gloda and no one has ever made a statement about forcing it on users? dredging up gloda issues digresses. thanks. That said, please add any technical or helpful information to relevant bugs, file a new bug, or post in a newsgroup - I've gloda bug lists on the wiki page of bugzilla queries under "global search/gloda/search all messages" https://wiki.mozilla.org/Thunderbird:Bug_Queries#Function-based_Queries

(In reply to Wayne Mery (:wsmwk) from comment #153)
> please can we agree that this bug is not about gloda

Yeppers...

> and no one has ever made a statement about forcing it on users?

Well, not directly, but Blake's comment about 'merging the Quick Filter Bar and GLODA' is what prompted my question...

I take it that what was meant was providing a dual action capability, similar to how the Unified Search allows you to perform both filtering, and Global Searches?

(In reply to Charles from comment #145)
> (In reply to Blake Winton [On vacation until Jan 9th] (:bwinton -
> Thunderbird UX) from comment #144)
> I had a few exchanges with Iago about simplifying the Widget, so hopefully
> I'll be able to post back here to try the new version soon and maybe some of
> your concerns will be addressed.
>
> > Well, it wasn't my decision, so I'm not particularly offended. (But I'm
> > also not convinced that only ever adding things, and never taking things
> > away is a path that will lead to good software.)
>
> Definitely me neither... but this is not one of those times. I absolutely
> love this addon, and can't imagine Thunderbird without it.

this is the case for many addons, for many people. Somewhere, there has been discussion about the standards bar for acceptance of addons into core. perhaps someone could post a link so discussion can continue in that venue.

> >> Ok, Blake, no offense, but you simply cannot be serious. It *does* make it
> >> more 'minimal', in the sense that it takes up less *space* *and* allows the
> >> user the freedom to put the searchbox wherever they want and be able to
> >> filter messages without having another huge toolbar taking up more precious
> >> screen real estate, which is *the* *whole* *point*.
>
> > I see that you and I are talking about two completely different things.
> >
> > I don't care how much space we take up, if we get an easier to use program.
>
> Sorry, again, no offense, but that comment just screams 'I know nothing
> about *good* UI design."

I suspect you take blake too literally, as we realistically aren't talking about gobs of space. Regardless, I don't see it implying anything about knowledge, but that the goals are different.

> >> Then you must have never bothered to read the opening comment. Too bad,
> >> because the loss of the movable search box was a huge blow for many, many
> >> people.
>
> > Perhaps it was, but I haven't heard that many people complaining about it.
> > (Maybe because Iago's add-on is satisfying their needs?)
>
> Well there was a lot of noise on mozillazine and other sites when this
> happened, but it was a long time ago (3.1 I believe), so sure, the noise has
> died down because people either found the addon, or modified their behavior,
> but I also distinctly recall a lot of people saying they switched email
> clients (it was like a 'last straw' kind of thing).

good or bad, change always brings these types of comments.

FWIW, we see very few complaints or suggestions in getsatisfaction about global search - even though there is significant room for improvement, as the aforementioned bug lists illustrate.

> > I understand that not everyone likes changes we make, but I still haven't
> > been convinced that the benefit of this would outweigh the cost.
>
> Well, in contrast, I honestly don't see the 'cost' in providing users the
> *option*.

there is *always* cost. more code always costs.

ATM I am not in a position to comment further about specific merits of the addon although generally like it, even though I am using it on one of my PCS, so please don't take that as a criticism.

> > Definitely me neither... but this is not one of those times. I absolutely
> > love this addon, and can't imagine Thunderbird without it.
>
> this is the case for many addons, for many people.

With one difference: this addon just re-adds functionality that was available in TB 2 and was removed in TB 3.

(In reply to Frank Steiner from comment #156)
>>> Definitely me neither... but this is not one of those times. I absolutely
>>> love this addon, and can't imagine Thunderbird without it.

>> this is the case for many addons, for many people.

> With one difference: this addon just re-adds functionality that was
> available in TB 2 and was removed in TB 3.

Precisely...

In fact, I have already approached Iago about the possibility of - *after* first simplifying things a bit and losing some of the clutter - incorporating the functionality of the 'View:...' widget too (the one that allows you to create Custom Saved Searches), which I also still must use, because of one feature: Persistent Views of folders - I can set some folders to always 'View: All' and some to 'View: Unread'...

So, if he can accomplish this, then incorporating Unified Search into the core code would *simplify* things (reduce redundancy and the resultant confusion).

I'll be opening another bug for this once I have a Screenshot done (of how the new widget would/could look) and a suggestion for how to incorporate the functionality in a way that makes sense.

When can we hope for a fix for this regression?

The QFB will redesigned, and a comment period will be announced at a future date in bug 1846359. Comments will gladly be accepted at that time.