Comment 294 for bug 52667

Revision history for this message
In , Blake Winton (bwinton) wrote :

Created an attachment (id=382629)
Disable menu items with further tweaks.

(In reply to comment #236)
> (From update of attachment 382384 [details])
> >+++ b/mail/base/content/mail3PaneWindowCommands.js
> > if (GetNumSelectedMessages() > 0)
> > if (gDBView)
gDBView.getCommandStatus(nsMsgViewCommandType.cmdRequiringMsgBody, enabled, checkStatus);
> >+ rv = enabled.value;
> While you're here, please combine this to one if statement, and then return
> early if (!enabled.value)

Done.

> >+ if (command == "cmd_reply" || command == "button_reply")
> >+ rv = IsReplyEnabled();
> >+ else if (command == "cmd_replyall" || command == "button_replyall")
> >+ rv = IsReplyAllEnabled();
> >+ else if (command == "cmd_replylist" || command == "button_replylist")
> >+ rv = IsReplyListEnabled();
> >+ return rv;
> Here too, no need for the rv, just |return IsReplyEnabled();| and so on

Done.

> Forgot to mention it earlier, but some doxygen documentation for the new
> methods would be nice. Something along the lines of
> /**
> * Get the folder type of the currently selected folder
> * @return the folder type, or null if we don't have a selected folder
> */

Done.

> r=mkmelin with those

Thank you!