Comment 281 for bug 52667

Revision history for this message
In , Blake Winton (bwinton) wrote :

Created an attachment (id=380027)
The latest version of the patch.

(In reply to comment #225)
> >+ try {
> >+ return msgHdr.folder.server.type;
> >+ } catch (ex) {
> catch on a new line

Done.

> >+ // This empty catch block needs to be here because, although
> >+ // msgHdr.folder will be null for .eml files, it will still throw an
> >+ // exception when you try to access it.
> >+ }
> >+ return null;
>
> But please just do this functionality inline instead of as a function. (And i
> think it should just say that it throws, not that it's null.)

Done, and done. I originally called the function twice, but later got rid of the second call, so I inlined the code.

> Otherwise looks good to me.

Thank you!
Blake.