Martin, sorry for not getting to the review sooner. Unfortunately, since you've submitted the trunk patch, the trunk code has changed enough such that it doesn't apply, even with various patch flag massaging. I've just spent about an hour wrapping my head around a bunch (thought not yet all) of the various comments here. Unfortunately, I'm not going to finish this evening, but I'll do some more tomorrow.
If you or someone else could un-bitrot the patch, that would be fantastic. If not, I'll try and find the bandwidth to do it. In any case, I'll poke some more at this tomorrow.
Martin, sorry for not getting to the review sooner. Unfortunately, since you've submitted the trunk patch, the trunk code has changed enough such that it doesn't apply, even with various patch flag massaging. I've just spent about an hour wrapping my head around a bunch (thought not yet all) of the various comments here. Unfortunately, I'm not going to finish this evening, but I'll do some more tomorrow.
If you or someone else could un-bitrot the patch, that would be fantastic. If not, I'll try and find the bandwidth to do it. In any case, I'll poke some more at this tomorrow.