Now I did some more testing...
Because I have these problems only with a Nextcloud "Birthdays from contacts"-calendar, I setupped a new Nextcloud instance with only a few contacts with a birthday in it. This calendar is in Nextcloud created automatically and write protected for all users. The events in this calendar have a reminder, that's timed for midnight and are for the whole day. For comparing I created also a "normal" calendar, with and without reminder settings in the events, with special durations and for the whole day. So the normal Calendar works like it should. the reminder pops up and is closeable with the close button in the window and doesn't throw an error. The birthday calendar reminders are only closable over the X in the titlebar an throw the error. The "illegal type for property: VALUE=DURATION"-error doesn't show up in no case anymore. So I think its for me another problem now and your patch does what it should.
I'll do some more testing also with my productive data, which has around 900 contacts with 300 birthdays, an about 5 calendars with plenty of events. :) so finally it looks like the birthday events are although the error shown in the calendar, whats for me definitely is an improvement. ;)
Now I did some more testing... -error doesn't show up in no case anymore. So I think its for me another problem now and your patch does what it should.
Because I have these problems only with a Nextcloud "Birthdays from contacts"-calendar, I setupped a new Nextcloud instance with only a few contacts with a birthday in it. This calendar is in Nextcloud created automatically and write protected for all users. The events in this calendar have a reminder, that's timed for midnight and are for the whole day. For comparing I created also a "normal" calendar, with and without reminder settings in the events, with special durations and for the whole day. So the normal Calendar works like it should. the reminder pops up and is closeable with the close button in the window and doesn't throw an error. The birthday calendar reminders are only closable over the X in the titlebar an throw the error. The "illegal type for property: VALUE=DURATION"
Lightning: CalDAV: Unexpected status modifying item to geburtstag aidlec: 404 -//Mozilla. org/NONSGML Mozilla Calendar V1.1//EN 20210718T071933 Z 20210718T071947 Z 20210718T071947 Z f539-4181- 841a-05d7280a61 a2 20210718T071947 Z VALUE=DATE: 19760717 DATE:19760718 BC-FIELD- TYPE:BDAY BC-UNKNOWN- YEAR:0 BC-YEAR: 1976 TIME-1626480000 000000: 20210718T072447 Z VALUE=DURATION: PT0S
BEGIN:VCALENDAR
PRODID:
VERSION:2.0
BEGIN:VEVENT
CREATED:
LAST-MODIFIED:
DTSTAMP:
UID:6f28a0d9-
SUMMARY:🎂 Jul Birthday (1976)
RRULE:FREQ=YEARLY
X-MOZ-LASTACK:
DTSTART;
DTEND;VALUE=
TRANSP:TRANSPARENT
X-NEXTCLOUD-
X-NEXTCLOUD-
X-NEXTCLOUD-
X-MOZ-SNOOZE-
X-MOZ-GENERATION:1
BEGIN:VALARM
ACTION:DISPLAY
TRIGGER;
DESCRIPTION:🎂 Jul Birthday (1976)
END:VALARM
END:VEVENT
END:VCALENDAR
I'll do some more testing also with my productive data, which has around 900 contacts with 300 birthdays, an about 5 calendars with plenty of events. :) so finally it looks like the birthday events are although the error shown in the calendar, whats for me definitely is an improvement. ;)