Comment on attachment 8620682
use GTK default paper size and orientation
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #89)
> So with this patch, do we still remember the user's paper size in some way?
Yes. The code removed here was not reading user's prefs. Those prefs were never saved.
> How?
(In reply to Karl Tomlinson (ni?:karlt) from comment #85)
> These are subsequently overridden by prefs if any have been saved from
> a previous nsPrintSettingsGTK.
This happens in nsPrintOptions from InitPrintSettingsFromPrefs(), called after
InitPrintSettingsFromPrinter().
Comment on attachment 8620682
use GTK default paper size and orientation
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #89)
> So with this patch, do we still remember the user's paper size in some way?
Yes. The code removed here was not reading user's prefs. Those prefs were never saved.
> How?
(In reply to Karl Tomlinson (ni?:karlt) from comment #85)
> These are subsequently overridden by prefs if any have been saved from
> a previous nsPrintSettingsGTK.
This happens in nsPrintOptions from InitPrintSettin gsFromPrefs( ), called after gsFromPrinter( ).
InitPrintSettin
https:/ /hg.mozilla. org/mozilla- central/ annotate/ 9ebd530c5843/ widget/ nsPrintOptionsI mpl.cpp# l542 /hg.mozilla. org/mozilla- central/ annotate/ 9ebd530c5843/ dom/base/ nsGlobalWindow. cpp#l7011
https:/