Comment 14 for bug 1995606

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thank you for your patience.

I believe Chris should be the one doing the review here, but I'd like to mention that it would be great if you could add DEP-3 headers to each patch:

https://dep-team.pages.debian.net/deps/dep3/

This helps us better document and understand where each patch came from.

Moreover, your debdiff is unnecessarily adding a ".pc" directory, which is generated by quilt. Please remove it.

Your d/changelog entry has a typo: s/doesnt/doesn't/

You have two patches numbered 0015-... in d/changelog, but only one actual 0015-... patch.

Finally, I don't see an answer to Chris' question regarding 0013-Ensure-there-is-one-trips-element-per-zone.patch.

Thanks!