Comment 9 for bug 1934221

Revision history for this message
Lukas Märdian (slyon) wrote (last edit ):

Thank you for providing a patch! That patch looks straight forward and (almost) resembles the upstream change, obviously missing the parts that do not yet exist in systemd v245.

The only other thing I found missing is an upstream change in src/resolve/resolved-dns-transaction.c:

```
 static void dns_transaction_stop_timeout(DnsTransaction *t) {
         assert(t);

- t->timeout_event_source = sd_event_source_unref(t->timeout_event_source);
+ t->timeout_event_source = sd_event_source_disable_unref(t->timeout_event_source);
 }

 DnsTransaction* dns_transaction_free(DnsTransaction *t) {
```

I've created a new patch for Focal, including this change and also adopted the patch to Hirsute.

I have a few open questions:
1/ Did you leave out that resolved-dns-transaction.c change on purpose?
2/ What is the best way to reproduce this issue? Can it somehow be triggered?
3/ How to test/confirm that the issue is indeed fixed? Is there any way other than observing for 24 hours?