While your use of self.sourceslist.add() seems good, I don't like how it is using similar logic that is in ppa.py in SoftwareProperties.py's add_source_from_line(). Wouldn't it be better to extract out the parts of new_deb_entry and new_debsrc_entry and give those parts to self.sourceslist.add()?
NAK pending comments from submitter. Please resubscribe ubuntu-sponsors once you have commented and/or upddated your patch. Thanks again!
Thanks for the patch Nick!
While your use of self.sourceslis t.add() seems good, I don't like how it is using similar logic that is in ppa.py in SoftwarePropert ies.py' s add_source_ from_line( ). Wouldn't it be better to extract out the parts of new_deb_entry and new_debsrc_entry and give those parts to self.sourceslis t.add() ?
NAK pending comments from submitter. Please resubscribe ubuntu-sponsors once you have commented and/or upddated your patch. Thanks again!