Building this locally with `git ubuntu build` failed with an error about symbols discrepancy:
dpkg-gensymbols: error: some new symbols appeared in the symbols file: see diff output below
dpkg-gensymbols: error: some symbols or patterns disappeared in the symbols file: see diff output below
dpkg-gensymbols: warning: debian/libsmbclient/DEBIAN/symbols doesn't match completely debian/libsmbclient.symbols
dh_makeshlibs: failing due to earlier errors
make[1]: *** [debian/rules:255: override_dh_makeshlibs] Error 255
make: *** [debian/rules:87: binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2
09/03/2019 18:41:28 - ERROR:Failed to build
However, the patchset does not remove any symbols, and the only function it adds is a static internal routine for printing some information. So I think this is a spurious error, but am doing a build in a PPA just to doublecheck.
Apart from that, the upload looks good to go:
√ Codereviewed patches
√ Verified patches match what was proposed upstream
√ Verified changelog text and format
√ Verified patches listed correctly in d/p/series
I don't have authorization to the upstream bug report, so was unable to verify that, but the change makes sense for fixing the issue it alludes to.
Building this locally with `git ubuntu build` failed with an error about symbols discrepancy:
dpkg-gensymbols: error: some new symbols appeared in the symbols file: see diff output below libsmbclient/ DEBIAN/ symbols doesn't match completely debian/ libsmbclient. symbols dh_makeshlibs] Error 255 buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2
dpkg-gensymbols: error: some symbols or patterns disappeared in the symbols file: see diff output below
dpkg-gensymbols: warning: debian/
dh_makeshlibs: failing due to earlier errors
make[1]: *** [debian/rules:255: override_
make: *** [debian/rules:87: binary] Error 2
dpkg-
09/03/2019 18:41:28 - ERROR:Failed to build
However, the patchset does not remove any symbols, and the only function it adds is a static internal routine for printing some information. So I think this is a spurious error, but am doing a build in a PPA just to doublecheck.
Apart from that, the upload looks good to go:
√ Codereviewed patches
√ Verified patches match what was proposed upstream
√ Verified changelog text and format
√ Verified patches listed correctly in d/p/series
I don't have authorization to the upstream bug report, so was unable to verify that, but the change makes sense for fixing the issue it alludes to.