Comment 24 for bug 1762889
Revision history for this message
| Gunnar Hjalmarsson (gunnarhj) wrote | #24 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
513534c
demo site
(Get the code!)
Hi Steve,
Since I'm the formal uploader of this SRU proposal, I'd better say something, even if I think that e.g. Laney and Didier are better prepared to comment on the approach.
For several cycles dh_translations has used its own, pretty simplistic, heuristic to detemine both the gettext domain and the build system. The introduction of Meson added some complexity:
- Not as straightforward to find the domain
- A need to figure out the build directory
So even if the actually used build system could be detected more easily (I'm not able to tell), we'd still need code to figure out the domain and the build directory.
The proposed upload is in substance just a backport of the version of the dh_translations script used in Cosmic, where it has proved to be helpful AFAIK. If there is room for improvements, can it wait until the 19.04 cycle, so we don't delay this SRU?