Incorrect warning message in Interfaces U/I
Bug #838099 reported by
Scott Kitterman
This bug affects 4 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
networkmanagement (Ubuntu) |
Fix Released
|
High
|
Mathieu Trudel-Lapierre | ||
Oneiric |
Fix Released
|
High
|
Mathieu Trudel-Lapierre |
Bug Description
Kubuntu Oneiric Beta 1 Testing: On the interfaces part of the widget U/I it says "We need NetworkManager version >= 0.8.9997 to work, found 0.9.0. Something seems bugged with the version detection. It does actually work.
Related branches
lp://staging/~cyphermox/ubuntu/oneiric/networkmanagement/lp838099
- Felix Geyer: Approve
-
Diff: 97 lines (+55/-2)5 files modifiedCMakeLists.txt (+1/-1)
debian/changelog (+8/-0)
debian/patches/nm_versions_comparison.patch (+44/-0)
debian/patches/series (+1/-0)
solidcontrolfuture/solid/CMakeLists.txt (+1/-1)
tags: | added: iso-testing |
Changed in networkmanagement (Ubuntu): | |
status: | New → Confirmed |
To post a comment you must log in.
So part of the issue here is that KDE_MAKE_VERSION shifts bits to make up an integer that will be comparable for version checks. Unfortunately, the large version number for NM 0.8.996 and all breaks in this case because the last number is larger than 255.
A similar issue exists for CMake's macro_ensure_ version, discovered while testing the fix.
So I've done a patch here to require NM 0.9.0 where the version gets checked, which is less intrusive than changing code in Cmake and KDE's macros (and in reality, not sure exactly how it would be best fixed there).