It is indeed more of stylistic reviews from the NetworkManager developers on the mailing list. To quote Dan Williams:
"So the reason this didn't get merged in the first place is that when
this is used, the auth dialog looks like ass. Having _3_ buttons there
has confused every user I've ever seen, and makes me read things a few
times whenever I get the dialog. It's just bad UI. Plus, it's not
something you can change in the connection editor out-of-band from
authentication. That's not to say it doesn't fill a need and fix the
bug, but the solution is not one I'd like to have upstream."
I tend to agree that the fix is not ideal in terms of "look and feel" and that's partly why I didn't immediately subscribe u-u-s, because it seemed unclear to be how to handle this patch in light of the discussions about debdiffs on ubuntu-devel mailing list, since it would need some major changes to be merged upstream (working on these changes atm, but not sure how long it will take).
James,
It is indeed more of stylistic reviews from the NetworkManager developers on the mailing list. To quote Dan Williams:
"So the reason this didn't get merged in the first place is that when
this is used, the auth dialog looks like ass. Having _3_ buttons there
has confused every user I've ever seen, and makes me read things a few
times whenever I get the dialog. It's just bad UI. Plus, it's not
something you can change in the connection editor out-of-band from
authentication. That's not to say it doesn't fill a need and fix the
bug, but the solution is not one I'd like to have upstream."
I tend to agree that the fix is not ideal in terms of "look and feel" and that's partly why I didn't immediately subscribe u-u-s, because it seemed unclear to be how to handle this patch in light of the discussions about debdiffs on ubuntu-devel mailing list, since it would need some major changes to be merged upstream (working on these changes atm, but not sure how long it will take).
Thanks,
Matt