Looks fine to me. Builds ok with just main, looks maintainable, no security issues, packaging looks good. Would be good to have a man page for /usr/bin/ncftool, but that won't hold up this MIR. Since these commands will be running as root, I spotted checked the code, and memory allocations, etc seem to be handled well.
There is a test suite available and I would like to see it enabled in the build as a condition of this MIR. 'make check' seems to work just fine without requiring network access. Marking 'In Progress'.
Looks fine to me. Builds ok with just main, looks maintainable, no security issues, packaging looks good. Would be good to have a man page for /usr/bin/ncftool, but that won't hold up this MIR. Since these commands will be running as root, I spotted checked the code, and memory allocations, etc seem to be handled well.
There is a test suite available and I would like to see it enabled in the build as a condition of this MIR. 'make check' seems to work just fine without requiring network access. Marking 'In Progress'.