Comment 8 for bug 399911

Revision history for this message
zl0i (sancheolz) wrote :

I made a same patch for my Samsung r60+ and it`s work correct. I think we need to place all patches for this notebooks in one bugreport. And I think good idea will be reconstruct structure like this:
.matches = {
    DMI_MATCH(DMI_SYS_VENDOR,"SAMSUNG ELECTRONICS CO., LDT."),
    DMI_MATCH(DMI_PRODUCT_NAME,"X360"),
},
and made it look like this:
.matches = {
    DMI_MATCH(DMI_SYS_VENDOR,"SAMSUNG ELECTRONICS CO., LDT."),
    DMI_MATCH(DMI_PRODUCT_NAME,"X360"),
},
{
    DMI_MATCH(DMI_SYS_VENDOR,"SAMSUNG ELECTRONICS CO., LDT."),
    DMI_MATCH(DMI_PRODUCT_NAME,"...R60..."),
},
{
    DMI_MATCH(DMI_SYS_VENDOR,"SAMSUNG ELECTRONICS CO., LDT."),
    DMI_MATCH(DMI_PRODUCT_NAME,"....."),
},
I don`t know is this code correct, but I think you understand my idea. So we need to check all keycodes matching(or set of fn keys), symptoms, model and place it in one prepared patch. And if we find that ALL samsung laptops has this bug and same patch, then patch will look like this:
if(DMI_SYS_VENDOR=="SAMSUNG...")
     /* do code to release keys for all samsung laptops */
So we need to find regularity in model of laptop to make universal patch.