Comment 22 for bug 1998643

Revision history for this message
Michael Reed (mreed8855) wrote :

Hi Don,

Here are the changes I made to the second patch

c1ea387d998a scsi: smartpqi: Stop using the SCSI pointer

drivers/scsi/smartpqi/smartpqi_init.c
@@ -7256,8 +7265,9 @@ static struct scsi_host_template pqi_driver_template = {
  .slave_alloc = pqi_slave_alloc,
  .slave_configure = pqi_slave_configure,
  .map_queues = pqi_map_queues,
- .sdev_attrs = pqi_sdev_attrs,
- .shost_attrs = pqi_shost_attrs,
+ .sdev_groups = pqi_sdev_groups,
+ .shost_groups = pqi_shost_groups,
+ .cmd_size = sizeof(struct pqi_cmd_priv),
 };

The issue here is that the added lines cause the build to break. If I didn't add

+ .sdev_groups = pqi_sdev_groups,
+ .shost_groups = pqi_shost_groups,

and keep

- .sdev_attrs = pqi_sdev_attrs,
- .shost_attrs = pqi_shost_attrs,

My guess is that it will build. I haven't tried it yet but wanted some guidance.