Comment 80 for bug 1848771

(In reply to jarkko.sakkinen from comment #49)
> (In reply to Ferry Toth from comment #45)
> > @jarko just tested with v5.8-rc1, result is the same as 5.1 - 5.6: crashes
> > on resume to boot screen, but setting tpm_tis.interrupts=0 resolves the
> > situation.
> >
> > Note the original reporter has a brainwashed chromebook Asus C302, I have a
> > brainwashed chromebook Acer 720P. In both cases tpm_tis.interrupts=0 solves
> > the problem.
> >
> > Other reporters may be experiencing unrelated issues.
> >
> > I had no time to bisect further today, will do tomorrow evening. and see if
> > I can confirm [a3fbfae82b4cb3ff9928e29f34c64d0507cad874]:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/
> > ?id=a3fbfae82b4cb3ff9928e29f34c64d0507cad874
>
> I found something truly weird based on your dmesg outputs:
>
> % git --no-pager grep IFX0102 drivers/char/tpm
> drivers/char/tpm/tpm_infineon.c: {"IFX0102", 0},
> drivers/char/tpm/tpm_tis.c: {"IFX0102", 0}, /* Infineon */
>
> I.e.
>
> tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16)
> tpm tpm0: tpm_try_transmit: send(): error -5
> tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts
> tpm_tis tpm_tis: Could not get TPM timeouts and durations
> tpm_tis 00:08: 1.2 TPM (device-id 0xB, rev-id 16)
> tpm tpm0: tpm_try_transmit: send(): error -5
> tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts
> tpm_tis 00:08: Could not get TPM timeouts and durations
> ima: No TPM chip found, activating TPM-bypass!
> tpm_inf_pnp 00:08: Found TPM with ID IFX0102
>
> The HID is associated with two drivers and the last log entry tells that
> tpm_inf_pnp was successfully initialized.
>
> Given that tpm_tis showed problems already in the in v4.15, it would clue
> that tpm_tis driver should not include IFX0102.
>
> Looking at
>
> Author: Kylene Jo Hall <email address hidden>
> Date: Sat Apr 22 02:39:52 2006 -0700
>
> [PATCH] tpm: add HID module parameter
>
> I recently found that not all BIOS manufacturers are using the specified
> generic PNP id in their TPM ACPI table entry. I have added the vendor
> specific IDs that I know about and added a module parameter that a user
> can
> specify another HID to the probe list if their device isn't being found
> by the
> default list.
>
> Signed-off-by: Kylene Hall <email address hidden>
> Signed-off-by: Andrew Morton <email address hidden>
> Signed-off-by: Linus Torvalds <email address hidden>
>
> and
>
> % git --no-pager grep ATM1200 drivers/char/tpm
> drivers/char/tpm/tpm_tis.c: {"ATM1200", 0}, /* Atmel */
> % git --no-pager grep BCM0101 drivers/char/tpm
> drivers/char/tpm/tpm_tis.c: {"BCM0101", 0}, /* Broadcom */
> % git --no-pager grep NSC1200 drivers/char/tpm
> drivers/char/tpm/tpm_tis.c: {"NSC1200", 0}, /* National */
>
> It looks like that that the author was not aware that tpm_infineon.c already
> was implemented for IFX0102. The errors come from non-TCG compatible TPM
> implemenation tried to be used with the TCG TIS driver.
>
> I'm not sure (yet) if this a full resolution of this bug but it is obviously
> something that should be first fixed before making any fast conclusions on
> further actions.
>
> If the issue still persists after fixing this, then it is easier to debug
> because the bug scoped down to the tpm_infineon driver.

93e1b7d42e1edb4ddde6257e9a02513fef26f715