Comment 25 for bug 1696325

I've got the same setup as the original report and the problem still exists on a fully upgrade BIOS and dock firmware (under certain circumstances).

1. the setup works with Thunderbolt 3 security disable (set to NONE) in the BIOS

2. with TB3 security set to "secure", cold plugging the dock leads to a non working setup, even replugging the dock can not make it work

during boot a error and a some kernel oops are logged (I'll attach the log file):

error message:

[ 5.194097] thunderbolt 0000:07:00.0: unexpected hop count: 1023
[ 5.195229] intel-lpss 0000:00:15.0: enabling device (0000 -> 0002)
[ 5.195250] ipmi device interface
[ 5.195679] thunderbolt 0000:07:00.0: NHI initialized, starting thunderbolt
[ 5.195682] thunderbolt 0000:07:00.0: allocating TX ring 0 of size 10
[ 5.195695] thunderbolt 0000:07:00.0: allocating RX ring 0 of size 10
[ 5.195706] thunderbolt 0000:07:00.0: control channel created
[ 5.195707] thunderbolt 0000:07:00.0: control channel starting...
[ 5.195709] thunderbolt 0000:07:00.0: starting TX ring 0
[ 5.195715] thunderbolt 0000:07:00.0: enabling interrupt at register 0x38200 bit 0 (0xffffffff -> 0xffffffff)

oops:

[ 5.195716] ------------[ cut here ]------------
[ 5.195717] thunderbolt 0000:07:00.0: interrupt for TX ring 0 is already enabled
[ 5.195739] WARNING: CPU: 6 PID: 203 at drivers/thunderbolt/nhi.c:106 ring_interrupt_active+0x20b/0x250 [thunderbolt]
[ 5.195739] Modules linked in: ipmi_devintf(+) thunderbolt(+) intel_lpss_pci(+) i2c_hid nvme_core(+) rtsx_pci(+) ipmi_msghandler intel_lpss hid pinctrl_sunrisepoint pinctrl_intel fjes(-)
[ 5.195747] CPU: 6 PID: 203 Comm: systemd-udevd Not tainted 4.19.0-13-generic #14-Ubuntu
[ 5.195748] Hardware name: HP HP ZBook Studio G3/80D4, BIOS N82 Ver. 01.37 01/03/2019
[ 5.195753] RIP: 0010:ring_interrupt_active+0x20b/0x250 [thunderbolt]
[ 5.195754] Code: 48 89 55 c8 4c 89 4d d0 e8 22 72 bd f6 4c 8b 4d d0 48 8b 55 c8 45 89 f0 4c 89 e1 48 89 c6 48 c7 c7 60 bb 0c c0 e8 17 ab 5d f6 <0f> 0b e9 38 ff ff ff 44 03 6a 60 e9 54 fe ff ff 41 0f b6 47 78 d3
[ 5.195755] RSP: 0018:ffffb0d681f7f9a0 EFLAGS: 00010086
[ 5.195757] RAX: 0000000000000000 RBX: 00000000ffffffff RCX: ffff9391618d8000
[ 5.195757] RDX: 0000000000000000 RSI: 0000000000000002 RDI: 0000000000000002
[ 5.195758] RBP: ffffb0d681f7f9d8 R08: 0000000000000000 R09: 0000000000022600
[ 5.195759] R10: 00000011cc6c3e93 R11: 000000000002cd30 R12: ffffffffc00cb1e9
[ 5.195760] R13: 0000000000038200 R14: 0000000000000000 R15: ffff9391615cb9c0
[ 5.195762] FS: 00007ff380e628c0(0000) GS:ffff93916f780000(0000) knlGS:0000000000000000
[ 5.195763] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 5.195763] CR2: 00007ff380e5f767 CR3: 00000004a0c60001 CR4: 00000000003606e0
[ 5.195765] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 5.195765] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 5.195766] Call Trace:
[ 5.195772] tb_ring_start+0xf4/0x190 [thunderbolt]
[ 5.195777] tb_ctl_start+0x3c/0x90 [thunderbolt]
[ 5.195783] tb_domain_add+0x60/0x150 [thunderbolt]
[ 5.195787] nhi_probe+0x2c6/0x560 [thunderbolt]
[ 5.195790] local_pci_probe+0x46/0x90
[ 5.195792] pci_device_probe+0x18d/0x1a0
[ 5.195795] really_probe+0x243/0x3b0
[ 5.195797] driver_probe_device+0xba/0x100
[ 5.195799] __driver_attach+0xe4/0x110
[ 5.195801] ? driver_probe_device+0x100/0x100
[ 5.195803] bus_for_each_dev+0x79/0xc0
[ 5.195806] ? kmem_cache_alloc_trace+0x1c8/0x1e0
[ 5.195808] driver_attach+0x1e/0x20
[ 5.195810] bus_add_driver+0x159/0x230
[ 5.195811] ? 0xffffffffc00d7000
[ 5.195812] driver_register+0x70/0xc0
[ 5.195813] ? 0xffffffffc00d7000
[ 5.195815] __pci_register_driver+0x57/0x60
[ 5.195820] nhi_init+0x2f/0x1000 [thunderbolt]
[ 5.195822] do_one_initcall+0x4a/0x1c4
[ 5.195824] ? free_pcp_prepare+0x4f/0xd0
[ 5.195827] ? _cond_resched+0x19/0x30
[ 5.195828] ? kmem_cache_alloc_trace+0x172/0x1e0
[ 5.195831] do_init_module+0x60/0x220
[ 5.195832] load_module+0x171e/0x1980
[ 5.195835] __do_sys_finit_module+0xbd/0x120
[ 5.195837] ? __do_sys_finit_module+0xbd/0x120
[ 5.195839] __x64_sys_finit_module+0x1a/0x20
[ 5.195841] do_syscall_64+0x5a/0x110
[ 5.195844] entry_SYSCALL_64_after_hwframe+0x44/0xa9
[ 5.195845] RIP: 0033:0x7ff3812f0219
[ 5.195846] Code: 00 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 47 fc 0c 00 f7 d8 64 89 01 48
[ 5.195847] RSP: 002b:00007ffe96c820e8 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
[ 5.195848] RAX: ffffffffffffffda RBX: 000055ef74677410 RCX: 00007ff3812f0219
[ 5.195849] RDX: 0000000000000000 RSI: 00007ff3811d4cad RDI: 0000000000000005
[ 5.195850] RBP: 00007ff3811d4cad R08: 0000000000000000 R09: 000055ef74677410
[ 5.195851] R10: 0000000000000005 R11: 0000000000000246 R12: 0000000000000000
[ 5.195852] R13: 000055ef7466ad70 R14: 0000000000020000 R15: 000055ef74677410
[ 5.195853] ---[ end trace 63e612ca10819668 ]---

3. Hotplugging the dock does work, boltd is correctly authorizing the dock. However some PCIe and ACPI error are logged:

[ 30.817390] pcieport 0000:00:1c.4: AER: Corrected error received: 0000:00:1c.4
[ 30.817402] pcieport 0000:00:1c.4: PCIe Bus Error: severity=Corrected, type=Physical Layer, (Receiver ID)
[ 30.817412] pcieport 0000:00:1c.4: device [8086:a114] error status/mask=00000001/00002000
[ 30.817419] pcieport 0000:00:1c.4: [ 0] RxErr (First)
[ 31.311978] hp_wmi: Unknown event_id - 131073 - 0x1
[ 32.318217] ACPI BIOS Error (bug): Failure creating [\_GPE._E4C.SPRT], AE_ALREADY_EXISTS (20180810/dswload2-316)
[ 32.318246] No Local Variables are initialized for Method [_E4C]
[ 32.318250] No Arguments are initialized for method [_E4C]
[ 32.318254] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20180810/psobject-221)
[ 32.318265] ACPI Error: Method parse/execution failed \_GPE._E4C, AE_ALREADY_EXISTS (20180810/psparse-516)
[ 32.318281] ACPI Error: Method parse/execution failed \_GPE._E4C, AE_ALREADY_EXISTS (20180810/psparse-516)
[ 32.318302] ACPI Error: AE_ALREADY_EXISTS, while evaluating GPE method [_E4C] (20180810/evgpe-509)