So after some additional testing it looks like NCQ Trim on the Samsung 8** drives still has "issues".
It looks like it mostly works, but once the drive gets saturated with a large trim *(i.e. deleting 5 kernel trees, and then fstrimming), the kernel starts to hit timeouts. Increasing the timeouts to 200 seconds or more appears to alleviate these errors, but upstream has already blacklisted the drive altogether for NCQ trim.
So after some additional testing it looks like NCQ Trim on the Samsung 8** drives still has "issues".
It looks like it mostly works, but once the drive gets saturated with a large trim *(i.e. deleting 5 kernel trees, and then fstrimming), the kernel starts to hit timeouts. Increasing the timeouts to 200 seconds or more appears to alleviate these errors, but upstream has already blacklisted the drive altogether for NCQ trim.
https:/ /git.kernel. org/cgit/ linux/kernel/ git/torvalds/ linux.git/ commit/ ?id=9a9324d3969 67