Ubuntu
linux-restricted-modules package

  1. Bug #1925522
  2. Comment #32

Comment 32 for bug 1925522

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Ok, performed a review of the NEW packages of fabric-manager-{450,460}. I'll accept them as is as none of those issues are blocking, but please fix those before proceeding with the SRUs. The packaging is in overall a bit on the 'weird' side, but Nvidia pieces can get a bit hairy.

List of minor issues to fix:
 - For fabric-manager-450 the Vcs-Browser field does not exist (looks like the 450 is not on available on github?). 460 seems to be there though.
 - fabric-manager-450 has .install, .links and .triggers for the 460 packages. These need to removed as they're just adding to the confusion.
 - In both packages in debian/rules there's a override_dh_auto_build: that does `rm -f lib*.so` - that seems like some leftover that needs cleanup.
 - In debian/rules the BRANCH variable is set to 999 instead of 450 and 460 respectively. I think this should be kept up to date with the packages that are being considered.

Accepting o/