Comment 10 for bug 1953587

Verification done for bionic-proposed.

There are no verification steps, but the description shows what to check for:
- It currently doesn't parse the downstream WHENCE.ubuntu file.
- Fix that and cleanup any errors flagged by the checker.

Note: these must be performed on the git repo per dep on `git ls-files`.

PS: Juergh, hope you don't mind someone else verifying this!
Otherwise, sorry, please feel free to revert the tag change.

bionic-updates:
---

$ git checkout Ubuntu-1.173.20

WHENCE.ubuntu? No.

$ strace -f -e openat -o open.log ./check_whence.py 2>/dev/null
$ grep WHENCE open.log
2725 openat(AT_FDCWD, "WHENCE", O_RDONLY) = 3

Clean of errors? No.

$ ./check_whence.py 2>&1 | awk '{ $2 = "FILE"; print $0 }' | sort | uniq -c
    131 E: FILE listed in WHENCE does not exist
    115 E: FILE not listed in WHENCE

bionic-proposed:
---

$ git checkout Ubuntu-1.173.21

WHENCE.ubuntu? Yes.

$ strace -f -e openat -o open.log ./check_whence.py 2>/dev/null
$ grep WHENCE open.log
2755 openat(AT_FDCWD, "WHENCE", O_RDONLY|O_CLOEXEC) = 3
2755 openat(AT_FDCWD, "WHENCE.ubuntu", O_RDONLY|O_CLOEXEC) = 3

Clean of errors? Yes.

$ ./check_whence.py 2>&1 | awk '{ $2 = "FILE"; print $0 }' | sort | uniq -c
$

What if we force one? It works.

$ vim WHENCE # remove last entry
$ git diff
diff --git a/WHENCE b/WHENCE
...
-
-Driver: ice - Intel(R) Ethernet Connection E800 Series
-
-File: intel/ice/ddp/ice-1.3.4.0.pkg
-Link: intel/ice/ddp/ice.pkg -> intel/ice/ddp/ice-1.3.4.0.pkg
-
-License: Redistributable. See LICENSE.ice for details

$ ./check_whence.py
E: LICENSE.ice not listed in WHENCE or WHENCE.ubuntu
E: intel/ice/ddp/ice-1.3.4.0.pkg not listed in WHENCE or WHENCE.ubuntu
E: intel/ice/ddp/ice.pkg not listed in WHENCE or WHENCE.ubuntu