Taking, I have a patch about ready that just needs some testing. Aside from the obvious fix of using this.setParameter() (which btw also appears in calRelation.js), I noticed that setting the ical property doesn't seem to reset the property bag. Therefore a testcase similar to the following will fail:
let icalAttach1 = getICSService().createIcalProperty("ATTACH");
let icalAttach2 = getICSService().createIcalProperty("ATTACH");
let attach = cal.createAttachment();
Taking, I have a patch about ready that just needs some testing. Aside from the obvious fix of using this.setParameter() (which btw also appears in calRelation.js), I noticed that setting the ical property doesn't seem to reset the property bag. Therefore a testcase similar to the following will fail:
let icalAttach1 = getICSService( ).createIcalPro perty(" ATTACH" ); ).createIcalPro perty(" ATTACH" ); hment() ;
let icalAttach2 = getICSService(
let attach = cal.createAttac
icalAttach1. setParameter( "X-THING" , "FOO");
attach.icalProperty = icalAttach1; eq(attach. getParameter( "X-THING" ), "FOO"); eq(attach. getParameter( "X-THING" ), null);
do_check_
attach.icalProperty = icalAttach2;
do_check_
Does this make sense? Or is there a use case for making the parameters stick?