Ubuntu
indicator-application package

packaging of libappindicator0-cil is in violation of the Debian CLI Policy, making ${cli:Depends} not work

Bug #560095 reported by Sense Egbert Hofstede on 2010-04-10

This bug affects 6 people

Affects		Status	Importance	Assigned to	Milestone
	banshee-community-extensions (Ubuntu)	Fix Released	High	Chow Loong Jin	Ubuntu ubuntu-10.04
	indicator-application (Ubuntu)	Fix Released	High	Chow Loong Jin	Ubuntu ubuntu-10.04

Bug Description

Indicator Application does not call dh_makeclilibs at the correct place, due to improper target (binary-arch) naming, causing conflicts with CDBS's internal binary-arch rule. Hints from the build log:

make: Circular binary/libappindicator0-cil <- binary-arch dependency dropped.

The attached debdiff fixes this bug, in addition to fixing a few more CLI policy violations found in the package.

Symptoms/Consequences:
Banshee's AppIndicator extension, which links references the AppIndicator DLL, does not depend on libappindicator0-cil, despite having ${cli:Depends} in the list of binary dependencies.

$ apt-cache depends banshee-extension-appindicator
    banshee-extension-appindicator
      Depends: banshee
      Depends: banshee-extensions-common
      Depends: indicator-applet
      Depends: indicator-application
      Depends: libglib2.0-cil
      Depends: libgtk2.0-cil
      Depends: libmono-addins0.2-cil
      Depends: libmono-corlib2.0-cil
      Depends: libnotify0.4-cil

See original description

Tags:

Related branches

lp://staging/~indicator-applet-developers/indicator-application/lucid

Merged into lp://staging/~ubuntu-desktop/indicator-application/ubuntu at revision 108

Ken VanDine: Pending requested 2010-05-21

lp://staging/ubuntu/lucid/banshee-community-extensions

lp://staging/ubuntu/lucid-proposed/indicator-application

Revision history for this message

Sense Egbert Hofstede (sense) wrote on 2010-04-10:

Dependencies.txt Edit (10.2 KiB, text/plain; charset="utf-8")

Revision history for this message

Sense Egbert Hofstede (sense) wrote on 2010-04-10:

If I'm correct it does not have to depend on indicator-applet or indicator-application, that's unnecessary.

Revision history for this message

Sense Egbert Hofstede (sense) wrote on 2010-04-10:

Chow Loong Jin pointed out that this is not an issue with the way banshee-extension-appindicator is packaged, but by the way 'libappindicator0-cil' is packaged. The way it is currently done is in violation of the Debian Policy and makes ${cli:Depends} work incorrect for packages that want to use libappindicator0-cil.

He said he would try to solve this bug.

affects:	banshee-community-extensions (Ubuntu) → indicator-application (Ubuntu)
Changed in indicator-application (Ubuntu):
assignee:	nobody → Chow Loong Jin (hyperair)
importance:	Undecided → Medium
status:	New → In Progress
summary:	- banshee-extension-appindicator doesn't depend on libappindicator0-cil, - but it has to + packaging of libappindicator0-cil is in violation of the Debian Policy, + making ${cli:Depends} not work
tags:	added: packaging

Revision history for this message

Chow Loong Jin (hyperair) wrote on 2010-04-10: Re: [Bug 560095] Re: banshee-extension-appindicator doesn't depend on libappindicator0-cil, but it has to

On Sunday 11,April,2010 02:39 AM, Sense Hofstede wrote:
> Chow Loong Jin pointed out that this is not an issue with the way
> banshee-extension-appindicator is packaged, but by the way
> 'libappindicator0-cil' is packaged. The way it is currently done is in
> violation of the Debian Policy and makes ${cli:Depends} work incorrect
> for packages that want to use libappindicator0-cil.
>
> He said he would try to solve this bug.

Solved. Please refer to the CLI policy[1] when doing any packaging work that
involves CLI libraries in the future to avoid these kinds of errors.

[1] http://pkg-mono.alioth.debian.org/cli-policy/

affects ubuntu/indicator-application
status triaged

After this is uploaded, banshee-community-extensions will have to be rebuilt for
the changes to propagate. Other reverse-depends might need to be rebuilt as
well, but I'm not sure if any exist.

  affects ubuntu/banshee-community-extensions
  status triaged
  assignee hyperair

--
Kind regards,
Chow Loong Jin (GPG: 0x8F02A411)
Ubuntu Developer

Changed in indicator-application (Ubuntu):
status:	In Progress → Triaged

Revision history for this message

Sense Egbert Hofstede (sense) wrote on 2010-04-11: Re: packaging of libappindicator0-cil is in violation of the Debian Policy, making ${cli:Depends} not work

$ apt-cache rdepends libappindicator0-cil
    libappindicator0-cil
    Reverse Depends:
      libappindicator-cil-dev

Unless other applications suffer from the same bug there are no other rdepends for libappindicator0-cil.

Chow Loong Jin (hyperair) on 2010-04-14

Changed in indicator-application (Ubuntu):
importance:	Medium → High
Changed in banshee-community-extensions (Ubuntu):
importance:	Undecided → High
summary:	- packaging of libappindicator0-cil is in violation of the Debian Policy, - making ${cli:Depends} not work + packaging of libappindicator0-cil is in violation of the Debian CLI + Policy, making ${cli:Depends} not work

Revision history for this message

Chow Loong Jin (hyperair) wrote on 2010-04-14:

indicator-application.debdiff Edit (3.0 KiB, text/plain)

Add a new debdiff that closes this bug in the changelog entry.

description:	updated
Changed in indicator-application (Ubuntu):
milestone:	none → ubuntu-10.04
Changed in banshee-community-extensions (Ubuntu):
milestone:	none → ubuntu-10.04

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-04-14:

This bug was fixed in the package indicator-application - 0.0.19-0ubuntu2

---------------
indicator-application (0.0.19-0ubuntu2) lucid; urgency=low

  * debian/control:
    + Set libappindicator0-cil and libappindicator-cil-dev to Arch: all
    + Make libappindicator0-cil depend on libappindicator0 >= ${source:Version}
      instead
  * debian/rules:
    + Fix ordering of dh_*cli* (LP: #560095)
  * debian/libappindicator0-cil.install,
    debian/libappindicator0-cil.installcligac:
    + Fix CLI policy breakage:
      - Wrong installation paths for GAC'd CLI libraries
      - Direct installation of GAC'd libraries
-- Chow Loong Jin <email address hidden> Wed, 14 Apr 2010 18:44:22 +0800

Changed in indicator-application (Ubuntu):
status:	Triaged → Fix Released

Brian Murray (brian-murray) on 2010-04-14

tags:

added: patch

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-04-14:

This bug was fixed in the package banshee-community-extensions - 1.6.0-1ubuntu3

---------------
banshee-community-extensions (1.6.0-1ubuntu3) lucid; urgency=low

  * debian/(control, rules):
    + Demote avant-window-navigator to suggests in banshee-extension-awn
    + Drop banshee-extension-telepathy; not installable due to dependency
      on telepathy-gabble >= 0.9 (LP: #559978)
    + Tighten build-dep on libappindicator-cil-dev due to missing clilibs
      in older versions (LP: #560095)
    + Drop indicator-applet and indicator-application from binary-deps of
      -appindicator
-- Chow Loong Jin <email address hidden> Thu, 15 Apr 2010 00:26:37 +0800