Comment 42 for bug 747197

Revision history for this message
In , Bzbarsky (bzbarsky) wrote :

So this is based on a totally drive-by skim of the patch:

1) NS_ARRAY_LENGTH is a nice macro. ;)
2) "content" and "cursor" can have URI values
3) The parser you wrote will fail to parse something like:

     content: "url(foo)" url(foo);

    correctly. You're right that GetPropertyCSSValue would be nice here...
4) "foo: bar" in CSS is a declaration, not a rule (the "// Test if the inline
    style contains rules that" comment)
5) The code for setting the URL value will not work for "content" and "cursor"
    because they can include things other than the URL.
6) I'm not sure how putting @import in the same list as property names will
    work -- the two don't even live in the same places...