(In reply to Lebar from comment #51)
> I've got some working code that I was going to submit to Phabricator, but I thought that I would check here first on the protocol for context menu changes. I opted for a "Reveal in Bookmark Tree" context menu entry in the Library that would navigate to the appropriate place in the tree and then highlight the entry in the right-hand panel (this seemed more sensible than devising a new window just to show path).
Hi Lebar, thank you for working on this, that's awesome! The behaviour sounds good to me (but it's not my call).
The reporter of this bug, `Alex Faaborg [:faaborg] (Firefox UX) ` has provided some UX feedback in comment 6. `Reveal in Bookmark Tree` sounds exciting (as in 'Rise the curtain on this bookmark!'), but probably plain vanilla `Open Containing Folder` will be best for Windows (perhaps with variations like `Open Enclosing Folder` for other operating systems, but don't worry about that now). FF also uses `Open Containing Folder` for downloads when you hover the folder icon.
> Is there some specific vetting process for menu/GUI changes? Are there other reviewers other than Mark or Marco that need to be included in the commits?
Looking at the official owners and peers of the [Bookmark and History (Places)](https://wiki.mozilla.org/Modules/Desktop_Firefox#Bookmarks_.26_History) module, Mark or Marco should be the right people to review this.
Just file your patch on phabricator first (make sure to link it to this bug by filling the bug number in the appropriate field) and set Mark as a reviewer. He will certainly advise you on the next steps.
I work for Thunderbird, but I'd love to see this fixed as you can see from my comments here from time immemorial ;-)
(In reply to Lebar from comment #51)
> I've got some working code that I was going to submit to Phabricator, but I thought that I would check here first on the protocol for context menu changes. I opted for a "Reveal in Bookmark Tree" context menu entry in the Library that would navigate to the appropriate place in the tree and then highlight the entry in the right-hand panel (this seemed more sensible than devising a new window just to show path).
Hi Lebar, thank you for working on this, that's awesome! The behaviour sounds good to me (but it's not my call).
The reporter of this bug, `Alex Faaborg [:faaborg] (Firefox UX) ` has provided some UX feedback in comment 6. `Reveal in Bookmark Tree` sounds exciting (as in 'Rise the curtain on this bookmark!'), but probably plain vanilla `Open Containing Folder` will be best for Windows (perhaps with variations like `Open Enclosing Folder` for other operating systems, but don't worry about that now). FF also uses `Open Containing Folder` for downloads when you hover the folder icon.
> Is there some specific vetting process for menu/GUI changes? Are there other reviewers other than Mark or Marco that need to be included in the commits?
Looking at the official owners and peers of the [Bookmark and History (Places)](https:/ /wiki.mozilla. org/Modules/ Desktop_ Firefox# Bookmarks_ .26_History) module, Mark or Marco should be the right people to review this.
Just file your patch on phabricator first (make sure to link it to this bug by filling the bug number in the appropriate field) and set Mark as a reviewer. He will certainly advise you on the next steps.
I work for Thunderbird, but I'd love to see this fixed as you can see from my comments here from time immemorial ;-)