Ubuntu
firefox package

  1. Bug #13214
  2. Comment #22

Comment 22 for bug 13214

Revision history for this message
In , Gavin Sharp (gavin-sharp) wrote :

Comment on attachment 300762
Patch 2

>Index: toolkit/xre/nsNativeAppSupportUnix.cpp

> gboolean save_yourself_cb(GnomeClient *client, gint phase,

>+ nsCOMPtr<nsISupportsPRBool> didSaveSession =
>+ do_CreateInstance(NS_SUPPORTS_PRBOOL_CONTRACTID);

Check for oom?

I'd refactor this method to first check for !status (and the "interact == GNOME_INTERACT_ANY" check within that) and return early to avoid the extra indentation.

You should probably have someone who knows the GNOME session support API better than I at least take a look at this. Addressing Myk's comment would be nice, but probably shouldn't block landing this. You might want to look into what the EM_RESTART code does to persist command line arguments.