Ubuntu
firefox-3.0 package

  1. Bug #239826
  2. Comment #81

Comment 81 for bug 239826

Revision history for this message
In , Bmcbride (bmcbride) wrote :

(In reply to comment #57)
> At least some of the browser.safebrowsing.* prefs are already effectively
> toolkit prefs (url-classifier code checks the .enabled prefs). I don't think we
> need to worry about using the infoURL pref in toolkit

Alright - that makes me feel better. The urlclassifier/safebrowsing split is a bit awkward at times.

> as long as there's suitable fallback (might want to remove the reportError...).

FWIW, reportError() is what browser code uses for that case. Any fallback should apply to both cases. Ideally, I'd like the buttons that open these URLs to just not show if the relevant pref is missing (or malformed). The text on these warning pages don't reference the buttons, so the pages will still make sense if the buttons are hidden. Filed bug 534545 for this.