Luca - thanks for the patch! Looks like your solution is the right one for KVM. I'd like to ensure that volume attachments continue to work on Xen (driver name 'phy' is Xen-specific, which used to be ignored by QEMU until recently). So a bit of extra logic may be necessary to differentiate XML generated for Xen and KVM. I'll test and will get back to you.
Luca - thanks for the patch! Looks like your solution is the right one for KVM. I'd like to ensure that volume attachments continue to work on Xen (driver name 'phy' is Xen-specific, which used to be ignored by QEMU until recently). So a bit of extra logic may be necessary to differentiate XML generated for Xen and KVM. I'll test and will get back to you.