[SRU Patch Available] Cinnamon custom keyboard shortcuts don't work until logout
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
cinnamon (Ubuntu) |
Fix Released
|
Low
|
Joshua Peisach | ||
Focal |
Fix Released
|
Low
|
Joshua Peisach | ||
Groovy |
Fix Released
|
Low
|
Joshua Peisach |
Bug Description
[Impact]
* The users who manually set their own Keyboard Shortcuts will not have them applied until a full
reset of Cinnamon occurs.
* This can be very annoying and the code insertion is adding a reverse trigger to the custom list keybinding, and then adding a dummy string in case it can't (if there is only one keybind).
[Test Case]
* The bug is simply reproducable by changing a Keyboard Shortcut and testing it. It will likely
not work until you log out and log in again.
[Regression Potential]
* This patch ensures that a GSettings change is fired every time-and to avoid regression, also make sure that there is an actual keyboard shortcut, a dummy shortcut is added to avoid further possible regression.
* Regression could be possible through primarily Python updates. I will keep noting if anything happens but so far, nothing has really broken.
* Through this change it looks like there won't be any regression. Later on I will backport more
patches added to cinnamon.
* Two commits were made on this-another one was a revisit that fixed one so it looks like we are stable enough to not have to worry about regressions.
* The updated version of this patch actually fixes a regression-we should be okay.
[Other Info]
* Backporting patch from Linux Mint upstream, solved a few other issues
* This is a FIXED patch to not mess up other patches and it also fixes a (probably) regression.
* This is my 3rd attempt, fixed changelog and version
[Original Description]
Description: Ubuntu 20.04 LTS
Release: 20.04
cinnamon: 4.4.8-4
cinnamon-
Steps to Reproduce:
- on Cinnamon desktop, run cinnamon-settings
- go to Keyboard > Shortcuts > Custom Shortcuts
- add a custom shortcut, or edit the command or shortcut of an existing custom shortcut
Expected behavior:
the shortcut should become active immediately
Actual behavior:
the shortcut does not work until you log out and log in again
This seems similar to bug #1243532, but I'm reporting this as a new bug now because it is cinnamon-specific. Other shortcuts (e.g. Close Window) are updated immediately, this only affects custom shortcuts. I think this bug appeared in 20.04.
affects: | gnome-settings-daemon (Ubuntu) → cinnamon (Ubuntu) |
Changed in cinnamon (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in cinnamon (Ubuntu): | |
importance: | Undecided → Low |
tags: | added: sru |
Changed in cinnamon (Ubuntu): | |
status: | Fix Released → Triaged |
Changed in cinnamon (Ubuntu Groovy): | |
status: | Triaged → Fix Released |
Changed in cinnamon (Ubuntu Focal): | |
assignee: | nobody → Joshua Peisach (itzswirlz) |
status: | New → In Progress |
summary: |
- Cinnamon custom keyboard shortcuts don't work until logout + [SRU Patch Available] Cinnamon custom keyboard shortcuts don't work + until logout |
description: | updated |
Changed in cinnamon (Ubuntu Focal): | |
importance: | Undecided → Low |
description: | updated |
I also reported this here: https:/ /github. com/linuxmint/ cinnamon/ issues/ 9375