[SRU Patch Available] Cinnamon custom keyboard shortcuts don't work until logout

I also reported this here: https://github.com/linuxmint/cinnamon/issues/9375

Fixed upstream in Cinnamon 4.6.6.

A workaround to not have to logout completely is to restart cinnamon via Alt+F2 > "r".

I will SRU this and let you know when it's ready.

A SRU is now available.

[Impact]

 * The users who manually set their own Keyboard Shortcuts will not have them applied until a full
 reset of Cinnamon occurs.
 * This can be very annoying and the code insertion is a line that will trigger Cinnamon to
 rebuild for the user.

[Test Case]

 * The bug is simply reproducable by changing a Keyboard Shortcut and testing it. It will likely
 not work until you log out and log in again.

[Regression Potential]

 * Through this change it looks like there won't be any regression. Later on I will backport more
 patches added to cinnamon.

 * Regression will probably happen, or will only happen later on when this version of Cinnamon becomes ancient.

[Other Info]

 * Backporting patch from Linux Mint upstream, solved a few other issues

Requesting sponsorship.

The attachment "1-4.4.8-4ubuntu1.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

The patch is actually a little broken and causes a small regression... so I'll be fixing the patch. I also messed up other patches in the process so I will fix it

[Impact]

 * The users who manually set their own Keyboard Shortcuts will not have them applied until a full
 reset of Cinnamon occurs.
 * This can be very annoying and the code insertion is a line that will trigger Cinnamon to
 rebuild for the user.

[Test Case]

 * The bug is simply reproducable by changing a Keyboard Shortcut and testing it. It will likely
 not work until you log out and log in again.

[Regression Potential]

 * Through this change it looks like there won't be any regression. Later on I will backport more
 patches added to cinnamon.

 * Regression will EVENTUALLY probably happen, or will only happen later on when this version of Cinnamon becomes ancient, but not in the anytime future

 * The updated version of this patch actually fixes a regression-we should be okay.

[Other Info]

 * Backporting patch from Linux Mint upstream, solved a few other issues
 * This is a FIXED patch to not mess up other patches and it also fixes a (probably) regression.

Requesting sponsorship.

I love when I mess up the versions. I fixed it and another small issue

SRU template is the same (mostly)

[Impact]

 * The users who manually set their own Keyboard Shortcuts will not have them applied until a full
 reset of Cinnamon occurs.
 * This can be very annoying and the code insertion is adding a reverse trigger to the custom list keybinding, and then adding a dummy string in case it can't (if there is only one keybind).

[Test Case]

 * The bug is simply reproducable by changing a Keyboard Shortcut and testing it. It will likely
 not work until you log out and log in again.

[Regression Potential]

 * Through this change it looks like there won't be any regression. Later on I will backport more
 patches added to cinnamon.

 * Two commits were made on this-another one was a revisit that fixed one so it looks like we are stable enough to not have to worry about regressions.

 * The updated version of this patch actually fixes a regression-we should be okay.

[Other Info]

 * Backporting patch from Linux Mint upstream, solved a few other issues
 * This is a FIXED patch to not mess up other patches and it also fixes a (probably) regression.
 * This is my 3rd attempt, fixed changelog and version

Fix was released in 20.10 groovy-need to mark it for 20.04

Usually we try to only consider SRUs for issues that have a high impact on users, as every SRU can potentially introduce regressions. Usually we wait to bunch up more changes in one SRU for lower priority changes too - but seeing that cinnamon doesn't have much movement from the SRU POV, I think we can just do it.

Anyway, I think it's good to go as an SRU. With my SRU-member hat on though, I'd like you to work a bit more on the Regression Potential field. Since as-is, the information there is not enough and the SRU might get rejected during review in the queue.

Could you do an exercise of looking at the change and trying to think: "if there's a bug in this code modification, what could potentially break?". This field is quite crucial to our SRU process, because it gives additional context on which things could be tested 'just to be sure' to check if there are regressions - and if there are regressions, it's easier to identify which change might have caused it. Could you write up something like that?

I could sponsor the package for you right now, but I'd prefer for us to have all the paperwork 'shiny'! Please poke me once this is done. Thanks!

Clearly I looked over this (stupid me)
If you want we *could* skip this, or put it in ubuntu0.2 for Cinnamon 4.4.8-4

Your choice. I can recreate the diff.

Sponsored to focal-proposed. Had to change the changelog entry to contain a proper LP bug link (the # was missing), but other than that it was fine. Let's wait for the SRU team to pick it up from the queue and review.

Hello Daniel, or anyone else affected,

Accepted cinnamon into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cinnamon/4.4.8-4ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Verification complete. Updated to proposed in Focal and was able to adjust the keyboard shortcuts and they automatically worked.

This bug was fixed in the package cinnamon - 4.4.8-4ubuntu0.1

---------------
cinnamon (4.4.8-4ubuntu0.1) focal; urgency=medium

  * Fix Keyboard Shortcuts Updating each time (LP: #1882375)

 -- Joshua Peisach <email address hidden> Tue, 14 Jul 2020 21:55:09 -0400

The verification of the Stable Release Update for cinnamon has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.