Comment 5 for bug 264275

I have updated my branch and added a python test (as opposed to bash script test) to bzrlib/tests/blackbox/test_add_symlink_wip.py however I get a return code error:

AssertionError: Unexpected return code
not equal:
a = 0
b = 3

Some questions
1) Can someone please advise how to let the test know that a non-zero error code is expected?
2) I plan to move this to a Unit test + errors.py test (rather than a Blackbox test) as per the 'Testing exceptions and errors' of http://doc.bazaar-vcs.org/developers/testing.html. Is this the correct thing to do?
3) I think the fix is pretty much on the right track at the moment - checking if the the folders above (but not including) the path being bzr add'ed are symlinks to a directory not under the working copy. I would appreciate any other feedback concerning how the fix is implemented.

Please note: I have not run the full test suite yet. I will do so later today and start to look at any failures.

Thanks again for the feedback to date,
Declan