Comment 4 for bug 264275

Revision history for this message
Declan McGrath (declanmg) wrote :

Thanks for the feedback, which I am currently using to help my updated implementation. My approach will be:

For any file/directory asked to be added
  - Get the osutils.realpath() of its parent directory and ensure that this is inside [ie. osutils.is_inside()] the osutils.realpath() of the tree.basedir
  - If not then raise an ContentsUnderSymLinkedDirectoryOutsideTreeNotSupported error

Note: This alogrithm has now been implemented in my branch but I have yet to test it properly - and it seems to be raising the error twice for some unknown reason.

I think I will be able to add a proper test to the blackbox tests for this soon.