Comment 15 for bug 356012

I spent quite a bit of time reviewing this and feel the the patch is correct. It applies cleanly to intrepid and hardy, has some fuzz on gutsy and needed small adjustments for dapper. I also verified the strings for dapper-intrepid, and there are no new string changes.

I went through the logic of the VerifyGetSigners by hand using desk-checking (see attached for review) for GoodSigners, BadSigners, WorthlessSigners, and NoPubKeySigners being either empty or not empty, and believe the patch to be correct.

I also added several tests to Michael's test suite to ensure apt is working properly after patching and did not introduce regressions. I'll make these available shortly.