[SDK ListItems] should allow controls on the left
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UX |
Fix Released
|
Low
|
Olga Kemmet | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Medium
|
Zsombor Egri |
Bug Description
Looking to this system settings design:
https:/
The list have list entries with that format
| [check] <Label> |
I've used a custom item for those doing that:
'ListItem.Base {
property string textEntry: "";
property bool checkStatus: false;
Row {
spacing: units.gu(2)
CheckBox {
}
Label {
text: textEntry
}
}
}"
But:
- that's not standard
- clicking on the label doesn't tweak the checkbox as it does for other controls (I can hack that easily if needed though)
- the UI might not be consistent with what is used in other place
This bug might also be a place to discuss if those items are fine to use or non coherent with our use of the toolkit in other places...
Related branches
- PS Jenkins bot: Approve (continuous-integration)
- Tim Peeters: Approve
-
Diff: 4615 lines (+4323/-22)35 files modifiedcomponents.api (+57/-0)
documentation/overview.qdoc (+5/-0)
modules/Ubuntu/Components/Themes/Ambiance/ListItemPanel.qml (+180/-0)
modules/Ubuntu/Components/Themes/Ambiance/ListItemStyle.qml (+36/-0)
modules/Ubuntu/Components/Themes/Ambiance/qmldir (+4/-0)
modules/Ubuntu/Components/plugin/plugin.cpp (+13/-0)
modules/Ubuntu/Components/plugin/plugin.pro (+14/-2)
modules/Ubuntu/Components/plugin/propertychange_p.cpp (+76/-0)
modules/Ubuntu/Components/plugin/propertychange_p.h (+39/-0)
modules/Ubuntu/Components/plugin/quickutils.cpp (+23/-0)
modules/Ubuntu/Components/plugin/quickutils.h (+1/-0)
modules/Ubuntu/Components/plugin/ucaction.h (+2/-0)
modules/Ubuntu/Components/plugin/uclistitem.cpp (+1260/-0)
modules/Ubuntu/Components/plugin/uclistitem.h (+126/-0)
modules/Ubuntu/Components/plugin/uclistitem_p.h (+202/-0)
modules/Ubuntu/Components/plugin/uclistitemactions.cpp (+541/-0)
modules/Ubuntu/Components/plugin/uclistitemactions.h (+113/-0)
modules/Ubuntu/Components/plugin/uclistitemactions_p.h (+61/-0)
modules/Ubuntu/Components/plugin/uclistitemactionsattached.cpp (+247/-0)
modules/Ubuntu/Components/plugin/uclistitemattached.cpp (+207/-0)
modules/Ubuntu/Components/plugin/uclistitemstyle.cpp (+70/-0)
modules/Ubuntu/Components/plugin/uclistitemstyle.h (+53/-0)
modules/Ubuntu/Components/plugin/ucstyleditembase.cpp (+2/-4)
modules/Ubuntu/Test/UbuntuTestCase.qml (+3/-6)
tests/qmlapicheck.sh (+1/-1)
tests/resources/listitems/ListItemTest.qml (+201/-0)
tests/unit/tst_performance/ItemList.qml (+30/-0)
tests/unit/tst_performance/ListItemList.qml (+30/-0)
tests/unit/tst_performance/ListItemWithActionsList.qml (+43/-0)
tests/unit/tst_performance/ListItemWithInlineActionsList.qml (+41/-0)
tests/unit/tst_performance/ListItemsBaseList.qml (+29/-0)
tests/unit/tst_performance/ListItemsEmptyList.qml (+29/-0)
tests/unit/tst_performance/tst_performance.cpp (+7/-8)
tests/unit/tst_performance/tst_performance.pro (+7/-1)
tests/unit_x11/tst_components/tst_listitem.qml (+570/-0)
Changed in ubuntu-ux: | |
assignee: | nobody → Katie Taylor (katie-t) |
Changed in ubuntu-ux: | |
status: | New → Opinion |
Changed in ubuntu-ui-toolkit: | |
assignee: | Florian Boucault (fboucault) → nobody |
Changed in ubuntu-ux: | |
assignee: | Katie Taylor (katie-t) → Giorgio Venturi (giorgio-venturi) |
status: | Opinion → New |
Changed in ubuntu-ui-toolkit: | |
status: | Incomplete → New |
Changed in ubuntu-ux: | |
importance: | Undecided → Low |
Changed in ubuntu-ui-toolkit: | |
importance: | Undecided → Low |
Changed in ubuntu-ux: | |
status: | New → Triaged |
Changed in ubuntu-ui-toolkit: | |
assignee: | nobody → Zsombor Egri (zsombi) |
status: | New → Confirmed |
importance: | Low → Medium |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Zsombor Egri (zsombi) |
importance: | Undecided → Medium |
status: | New → In Progress |
no longer affects: | ubuntu-ui-toolkit |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Committed |
summary: |
- [ListItems] should allow controls on the left + [SDK ListItems] should allow controls on the left |
Changed in ubuntu-ux: | |
assignee: | Giorgio Venturi (giorgio-venturi) → Olga Kemmet (olga-kemmet) |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Fix Committed → Fix Released |
Changed in ubuntu-ux: | |
status: | Triaged → Fix Released |
I'm pretty sure it's something the designers have to resolve between themselves as to ensure consistency.