Using Puppet stdlib in TripleO is risky because it exposes deployments
to dependency cycles in the catalog.
We should rather use native functions to make orchestrations, like
ordering and dependencies management.
This patch:
- removes usage of stages from stdlib
- use ordering to make sure we run pre rules before post
- use ordering to make sure we start all Services in catalog before post
rules. It ensure that we don't drop all traffic before starting the
services, which could lead to services errors (e.g. trying to reach database
or amqp)
Reviewed: https:/ /review. openstack. org/545110 /git.openstack. org/cgit/ openstack/ puppet- tripleo/ commit/ ?id=aaef9993c9f fb21df25fffe2cf 6bae2a979306a0
Committed: https:/
Submitter: Zuul
Branch: stable/newton
commit aaef9993c9ffb21 df25fffe2cf6bae 2a979306a0
Author: Emilien Macchi <email address hidden>
Date: Mon Nov 21 09:57:09 2016 -0500
firewall: stop using stdlib stages
Using Puppet stdlib in TripleO is risky because it exposes deployments
to dependency cycles in the catalog.
We should rather use native functions to make orchestrations, like
ordering and dependencies management.
This patch:
- removes usage of stages from stdlib
- use ordering to make sure we run pre rules before post
- use ordering to make sure we start all Services in catalog before post
rules. It ensure that we don't drop all traffic before starting the
services, which could lead to services errors (e.g. trying to reach database
or amqp)
Change-Id: Iec4705d6b785a4 0ccf6f43809b94b 726ccd47fef faaf46eec2bddf7 67ec49282f7 69e5ae181981e55 9ccc77371f)
Depends-On: Ib203161b9676dc
Closes-Bug: #1643575
(cherry picked from commit 2ca3cb03ad5f054