Like you said earlier, since we are getting rid of NoteCollection to the profit of a db that should handle all of this better, I'm not putting a lot of effort to make a clean fix.
Attached is my attempt at an ugly fix (warning: I'm no synchronization expert). Since ViewNote is also using findNoteFromTitle(...) I decided to make the method synchronized and dropped your patch.
I also synchronized buildNoteLinkifyPattern() and it did fix the crasher I experienced in comment #3.
I tested performance using the benchmark patch in doc/dev/threading-improvement/ and didn't notice any performance regression. Results added to benchmarks.txt
Can you test the patch and tell me if it fixes yours? I am no longer able to reproduce and not sure if I was ever able to..
Like you said earlier, since we are getting rid of NoteCollection to the profit of a db that should handle all of this better, I'm not putting a lot of effort to make a clean fix.
Attached is my attempt at an ugly fix (warning: I'm no synchronization expert). Since ViewNote is also using findNoteFromTit le(...) I decided to make the method synchronized and dropped your patch.
I also synchronized buildNoteLinkif yPattern( ) and it did fix the crasher I experienced in comment #3.
I tested performance using the benchmark patch in doc/dev/ threading- improvement/ and didn't notice any performance regression. Results added to benchmarks.txt
Can you test the patch and tell me if it fixes yours? I am no longer able to reproduce and not sure if I was ever able to..