Comment 38 for bug 1068921

Comment on attachment 675468
call DiscardNewMessage properly, only update size when downloading full message

Review of attachment 675468:
-----------------------------------------------------------------

This looks fine afaict. It seems to do the right things and doesn't break existing tests.

::: mailnews/base/util/nsMsgDBFolder.cpp
@@ +1721,5 @@
> + ReleaseSemaphore(static_cast<nsIMsgFolder*>(this));
> + if (msgStore)
> + // this closes the stream
> + msgStore->DiscardNewMessage(m_tempMessageStream, m_offlineHeader);
> + else

nit: blank space on end of line

::: mailnews/imap/src/nsImapProtocol.cpp
@@ +3270,5 @@
>
> if (NS_SUCCEEDED(rv))
> ParseIMAPandCheckForNewMail(commandString.get());
> GetServerStateParser().SetFetchingFlags(false);
> + m_fetchingWholeMessage = false;

For the two false cases, please can you include the comment:

// Always clear this flag after every fetch.

as I think it'll just help make it a bit more sense (and reflects what was there before)