Comment 5 for bug 1695935

> 1. Choice of 50px step. Will cause different behaviour for someone who switches to and from a HiDPI
> display - on HiDPI it will jump about half the lines of text. Even with single DPI the first press
> could step x lines of text, then the second press step x-1 lines depending on fontsize. I think a
> better approach would be to have a jump factor z, and multiply the font width/height by z.

Well, that's why it's configurable. Everyone could set it to whatever works best for them on their concrete system. 50 is just the default, because I had to put a number there, but we can make the default 10, for example (I myself use 100). The existing "crtl + shift + arrow" approach does not use any jump factors either, it just resizes by a fixed amount of 10 IIUC. (as said in my second comment, we could just keep that mechanism without adding new stuff and simply make the "10" configurable, I'm fine with that).

> 2. I'm not on my Linux system right now, so can't confirm, but I have a feeling you're overriding
> a built-in libvte shortcut for scrolling. I would be very hesitant to set those. I'd much rather
> leave it for those that need it to find their own shortcut.

Sure, the binding can be changed (and the default too, of course). I chose shift + arrow because it was unused in my setup and was simpler than crtl + shift + arrow. Do you have a suggestion for a usable default shortcut that would not interfere with anything?

> 3. No Preferences option for changing the step size (or factor as per 1). Means to change it
> people have to start editing config files.

Oh! You're right, I though adding it to prefseditor.py would make it appear in the graphical config. I'll try to fix that.

> 4. No man page updates documenting the new option. (I will take care of the online manual at
> readthedocs.)

Ok, that's easy, I'll add it as well.

Thanks for the feedback.