Comment 56 for bug 1662544

Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :

Stephen, whenever you come back to this, I recommend that you do some commit-squashing and similar bookkeeping type of work on Roman's branch, rather than merging it as-is. It's some extra work, but results in a much cleaner commit history.

It's 67 patches at this moment, most of them are super tiny. Instead, they could probably be made into about a dozen patches of reasonable size and reasonably related functional changes. E.g.:

Many patches only change the shebang line of one file. A single patch should change them all, at once.

r1825 contains a few functional changes, and tons of whitespace fixes. Whitespace fixes (if desired at all) should receive their separate change.

Many changes add another extra pair of parentheses to a "print" call, making it IMO unnecessarily harder to read. I would drop them.

Quite a few changes change back and forth between "next" and "__next__", the final desired state should be achieved in a single commit.

All changes to debian/* could probably be squashed.

In fact, IMO the few tiny actual python3 code fixes could also be squeezed into a single change.

Etc...