@acoles patch doesn't apply cleanly with `git am` because it was formatted with `git show`
So I started with a fresh merge from master yesterday:
git checkout master
0279411 Merge "versioned writes middleware"
Then I popped off to another branch to add the commits
git checkout -b fix-container-tempurl
Then I applied the fix from lp bug #1453948 comment #15
git am < dlo-tempurl.patch
Then I applied the fix in comment #82 (seems to require 3-way)
git am -3 < container-tempurl.patch
Those changes taken together works well for me. I understand our new functional tests we should be validating the behaviors we're tracking. I also agree with @acoles suggested cleanups in comment #83 - but we'll need to reformat that patch.
@acoles patch doesn't apply cleanly with `git am` because it was formatted with `git show`
So I started with a fresh merge from master yesterday:
git checkout master
0279411 Merge "versioned writes middleware"
Then I popped off to another branch to add the commits
git checkout -b fix-container- tempurl
Then I applied the fix from lp bug #1453948 comment #15
git am < dlo-tempurl.patch
Then I applied the fix in comment #82 (seems to require 3-way)
git am -3 < container- tempurl. patch
Those changes taken together works well for me. I understand our new functional tests we should be validating the behaviors we're tracking. I also agree with @acoles suggested cleanups in comment #83 - but we'll need to reformat that patch.