Comment 2 for bug 1639244

Revision history for this message
Alistair Coles (alistair-coles) wrote :

admin6 reported that the frags referred to in the logs do appear in quarantine directories.

Some of the reported error logs are raised from the ECDiskFileReader close() method. Some are raised from check_frags called during the reader iter.

Kota and I suspect that two calls are being made to the quarantine renamer, the second of which would fail with "No such file" error. But we could not see how that could happen in code paths.

If a chunk is read in ECDiskFileREader iter and check_frag finds corruption then the file will be quarantined, but reader._read_to_eof will be false so when closing the reader there will be no further call to check_frag.

Conversely, if the iter reaches end of file without a corruption being found, then the close() method will call check_frag with any remaining frag buf contents.

But, we couldn't see how both could occur.