Comment 8 for bug 1893669

Reviewed: https://review.opendev.org/c/starlingx/config/+/786147
Committed: https://opendev.org/starlingx/config/commit/8cc522bed57aac4699fed1b2cdf7cf4b213a4dc7
Submitter: "Zuul (22348)"
Branch: master

commit 8cc522bed57aac4699fed1b2cdf7cf4b213a4dc7
Author: Adriano Oliveira <email address hidden>
Date: Tue Apr 13 19:21:54 2021 -0400

    sysinv-api script to return ERROR

    Remove NOT_RUNNING return in case sysinv-api pid is still active but
    fails to ping. This scenario can happen in case sysinv-api is manually
    killed and SM triggers a start.
    Also, on the new routine to check if sysinv-api is properly replying,
    return ERROR instead of NOT_RUNNING for SM consistency.

    Testing:
    Tested double sysinv-api kill withing 90 seconds as per SM
    configuration. Upon first sysinv-api kill it should be restarted,
    upon second sysinv-api kill, if done within 90 seconds, a swact is
    triggered. Also verified that sysinv-api request routine was engaged.
    Also tested AIO-DX boostrap, manual swact via host-swact and patch
    application. After boostrap and patch application tested double
    sysinv-api kill and manual swact.

    Other fix related to this issue was addressed by this change:
    https://review.opendev.org/c/starlingx/stx-puppet/+/783980

    Closes-Bug: 1893669
    Signed-off-by: Adriano Oliveira <email address hidden>
    Change-Id: I1b1ab0560237f602dadf074331f6a165d12330c7