On Tue, Sep 27, 2016 at 11:08 AM, Sergio Schvezov <
<email address hidden>> wrote:
> Did it actually finish processing on the store side? With the data
> returned from the store (which is a state) all snapcraft can do is
> timeout but that doesn't feel like a good idea if the store just happens
> to be slow to process the snap.
>
I don't know - I can't find anything in the staging store logs that looks
like the same error. However, ISTM that the store has returned something,
otherwise we wouldn't see the json decode error. I think it's safe to
assume that if the store returns something that's invalid snapcraft should
treat that as an error, and abort the release process?
Is there some way to make snapcraft log the response body in cases like
this? In any case, catching JSONDecodeError and adding a nice log message
is probably a valuable addition to snapcraft no matter what the eventual
outcome of this bug is.
Hi,
On Tue, Sep 27, 2016 at 11:08 AM, Sergio Schvezov <
<email address hidden>> wrote:
> Did it actually finish processing on the store side? With the data
> returned from the store (which is a state) all snapcraft can do is
> timeout but that doesn't feel like a good idea if the store just happens
> to be slow to process the snap.
>
I don't know - I can't find anything in the staging store logs that looks
like the same error. However, ISTM that the store has returned something,
otherwise we wouldn't see the json decode error. I think it's safe to
assume that if the store returns something that's invalid snapcraft should
treat that as an error, and abort the release process?
Is there some way to make snapcraft log the response body in cases like
this? In any case, catching JSONDecodeError and adding a nice log message
is probably a valuable addition to snapcraft no matter what the eventual
outcome of this bug is.
Cheers,
--
Thomi Richards
<email address hidden>