Comment 2 for bug 1240717

Applied.

The real problem here is that commands executed on the build machine,
particularly at the level of NCPUS, are mostly irrelevant to client installs.

The further issue is that NCPUS is a "soft" command: its trivial to conceive
a need for uniprocessor builds on a multi-processor machine, i.e. the actual
NCPUS is most irrelevant/naive to how the NCPUS value is actually used.

Portability for commands determining per-os NCPUS is a trip through the
whorehouse of uglix as well.

OTOH, there are well known library API's (unlike scripts) for determining NCPUS,
and rpm already "knows" NCPUS portably using those library API's. SO the eventual
fix will be devising a better paradigm for configuring rpmbuild than "make -j$NCPUS"
and just rip out all of this hysterical baggage.

Meanwhile the patch is perfect for now, hurts nothing, will be in rpm-5.4.14. Thanks!