Need support for required sreg attributes
Bug #810978 reported by
Michael Nelson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ratings and Reviews server |
New
|
Undecided
|
Unassigned | ||
Software Center Agent |
Fix Released
|
Undecided
|
Unassigned | ||
django-openid-auth |
Fix Released
|
Undecided
|
Michael Nelson |
Bug Description
Similar to bug 810626, currently most ISD apps that use SSO use django-openid-auth - which only sets email, fullname and nickname as optional fields in the SRegRequest.
We'll need support for required sreg attributes before SSO can update to allow users to choose which optional fields they share with the consumer.
Perhaps an OPENID_
Related branches
lp://staging/~michael.nelson/django-openid-auth/810978-required-sreg
- Anthony Lenton: Approve
-
Diff: 300 lines (+105/-27)3 files modifieddjango_openid_auth/auth.py (+17/-11)
django_openid_auth/tests/test_views.py (+69/-12)
django_openid_auth/views.py (+19/-4)
Changed in software-center-agent: | |
assignee: | nobody → Michael Nelson (michael.nelson) |
Changed in django-openid-auth: | |
assignee: | nobody → Michael Nelson (michael.nelson) |
status: | New → In Progress |
Changed in software-center-agent: | |
assignee: | Michael Nelson (michael.nelson) → nobody |
Changed in software-center-agent: | |
status: | Confirmed → Fix Committed |
Changed in canonical-payment-service: | |
importance: | Undecided → Medium |
Changed in canonical-payment-service: | |
status: | New → Confirmed |
Changed in django-openid-auth: | |
status: | In Progress → Fix Released |
Changed in software-center-agent: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I've checked software- center- agent, and it won't error if someones logs in for the first time without selecting any of the optional sreg attributes - it'll just create a user with username= openiduserX and no email.
The no email *is* an issue, as currently we need one to be able to 'check or create lp user' when a person purchases software (and raise a web service error if that method is called without one). So we'd need to ensure that at least email was required.
Another option which lifeless suggested on bug 810626 would be a great work-around for the moment: "Sounds like perhaps [SSO] should treat optional as required for trusted/internal sites, as a migration facility."