Launchpad itself

launchpad should mark required sreg attributes as required

Bug #810626 reported by Ricardo Kirkner
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Canonical SSO provider
Fix Released
Undecided
Unassigned
Launchpad itself
Fix Released
Critical
William Grant

Bug Description

We're releasing a feature to allow end-users to decide which attributes to share with the consumer site (see bug #121533).
While testing this on staging, we found that the username and email sreg attributes, while marked as optional result in an oops (bug #810623) if not provided. They should probably be marked as required.

Related branches

lp://staging/~wgrant/launchpad/bug-810626
William Grant (community): Approve
Diff: 25 lines (+3/-1)
2 files modified
lib/canonical/launchpad/webapp/login.py (+1/-1)
lib/canonical/launchpad/webapp/tests/test_login.py (+2/-0)
Revision history for this message
Francis J. Lacoste (flacoste) wrote :

Escalated by ISD because they are waiting on us to fix this to deploy their new version.

Changed in launchpad:
status: New → Triaged
importance: Undecided → Critical
tags: added: escalated
William Grant (wgrant)
Changed in launchpad:
assignee: nobody → William Grant (wgrant)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13441 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13441>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Michael Nelson (michael.nelson) wrote :

Ricardo - I'm guessing you guys haven't checked any ISD apps against staging SSO, as afaics, django-openid-auth also uses optional sreg attributes only (and we use it for all our apps). I've created bug 810978 to track that.

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 810626] Re: launchpad should mark required sreg attributes as required

Sounds like perhaps we should treat optional as required for
trusted/internal sites, as a migration facility.

Revision history for this message
Stuart Metcalfe (stuartmetcalfe) wrote :

Agreed. We'll get this done before the production deployment.

William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
Ricardo Kirkner (ricardokirkner)
Changed in canonical-identity-provider:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.