There's quite a bit of code and comments that indicating that to moderate reviews a user needs to be a member of a specific Launchpad group (rnr-moderators), but the current implementation of LPAuthorizer.user_can_moderate just checks for membership in the local Django group (and doesn't use a webservice).
I'm assuming the implementation is correct (much nicer than requiring a LP group membership and having to verify via API etc.), but we should remove all the old code and comments (I was quite confused).
If this is the case, we should remove LPAuthorizer.
There's quite a bit of code and comments that indicating that to moderate reviews a user needs to be a member of a specific Launchpad group (rnr-moderators), but the current implementation of LPAuthorizer. user_can_ moderate just checks for membership in the local Django group (and doesn't use a webservice).
I'm assuming the implementation is correct (much nicer than requiring a LP group membership and having to verify via API etc.), but we should remove all the old code and comments (I was quite confused).
If this is the case, we should remove LPAuthorizer.