Comment 9 for bug 663645

Revision history for this message
Jeff Fortin Tam (kiddo) wrote : Re: Ingredients List should be a gtk.ListView

Hey, haven't inspected the code yet (not my area of expertise anyway ;), but here's some early feedback on the UI.
- The "New ingredient" and "New step" buttons are inside the scrolling area. They should probably be just outside.
- (related): creating a new ingredient/step should auto-scroll to the bottom to focus it
- The scrollbars should only show up when needed (set their visibility to automatic)?
- The multiline text fields in "directions" should have some sort of border. Like gtk.entry's set_inner_border method I think. The main branch has that, it looks ugly without it ;)
- The new ingredient/step buttons have an associated icon in the main branch, is it intentional that they're gone?
- It doesn't yet remember the window size ;)
- Those warning don't happen in the main branch:

(recipemanager:12086): libglade-WARNING **: could not look up stock id 'Import'
(recipemanager:12086): libglade-WARNING **: could not look up stock id 'Export'
(recipemanager:12086): libglade-WARNING **: could not look up stock id 'Print Recipe Book'
(recipemanager:12086): libglade-WARNING **: could not look up stock id 'Edit Recipe'
(recipemanager:12086): libglade-WARNING **: could not look up stock id 'View Recipe'