QBzr

  1. Bug #295130
  2. Comment #5

Comment 5 for bug 295130

Revision history for this message
Mark Hammond (mhammond) wrote : Re: A way to preview of changes before pushing in the Qpush dialog

Initial comments:

* There are some spurious changes: specifically, readme.txt has an EOL only change, commit.py and main.py have some whitespace-only changes, statuscache.py has only a commented-out print, qbzr-merge.png has an unmentioned change. FYI, "bzr [q]diff -rancestor:..\path-to-trunk" is what I'm using to preview the changes...

* main.py adds imports for ChangeDesc and closure_in_selected_list, but neither are used.

* The new 'if checkedFiles...' block looks suspect - if not self.pending_merges, it appears checkedFiles will always be zero, so therefore cause the checkbox? Also, see Python's pep8 - it should probably be checked_files.

* Comments "# FIXME need to find a way to extract this from the commit.py file" and " # FIXME get this from INFOWindow ui" - any thoughts on them? Why are they hard (ie, why not include a patch for them too?)

I haven't previewed the UI changes, but it looks very promising :)