Comment 1 for bug 1741911

Revision history for this message
Javier Peña (jpena-c) wrote :

This is currently breaking the Magnum gate, see [1]. I've been looking at the code, and what I've found is:

Magnum inits DriverCommandManager using None as a namespace parameter [2]. With the cliff change, the _load_commands() method skips any loading, see [3], so this is causing the unit test error, which btw is also seen in the upstream gate.

I'm not sure if setting namespace as None is valid, so this could be fixed on the Magnum side or on the cliff side (if it's expected to be valid). Apparently, using None as a namespace is relatively widespread [4].

[1] -http://logs.openstack.org/30/529330/2/check/openstack-tox-py27/2e898ff/job-output.txt.gz#_2018-01-10_16_13_06_384428
[2] - https://github.com/openstack/magnum/blob/master/magnum/cmd/driver_manage.py#L87-L93
[3] - https://github.com/openstack/cliff/blob/2.10.0/cliff/commandmanager.py#L55-L56
[4] - http://codesearch.openstack.org/?q=CommandManager%5C(None&i=nope&files=&repos=